Skip to content

Commit faba92f

Browse files
committed
split kinds
1 parent 75769fe commit faba92f

File tree

8 files changed

+42
-26
lines changed

8 files changed

+42
-26
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
export * from './menu-item-default.element.js';
2+
export * from './link/index.js';
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from './types.js';

src/packages/core/menu/components/menu-item/link/link-menu-item.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { UmbMenuItemElement } from '../../../menu-item-element.interface.js';
2-
import type { ManifestMenuItemLinkKind } from '../../../menu-item.extension.js';
2+
import type { ManifestMenuItemLinkKind } from './types.js';
33
import { customElement, html, property } from '@umbraco-cms/backoffice/external/lit';
44
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
55

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import type { ManifestMenuItem, MetaMenuItem } from '../../../menu-item.extension.js';
2+
3+
export interface ManifestMenuItemLinkKind extends ManifestMenuItem {
4+
type: 'menuItem';
5+
kind: 'link';
6+
meta: MetaMenuItemLinkKind;
7+
}
8+
9+
export interface MetaMenuItemLinkKind extends MetaMenuItem {
10+
href: string;
11+
}
12+
13+
declare global {
14+
interface UmbExtensionManifestMap {
15+
umbLinkMenuItemKind: ManifestMenuItemLinkKind;
16+
}
17+
}

src/packages/core/menu/menu-item.extension.ts

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -15,31 +15,8 @@ export interface MetaMenuItem {
1515
icon?: string;
1616
}
1717

18-
export interface ManifestMenuItemTreeKind extends ManifestMenuItem {
19-
type: 'menuItem';
20-
kind: 'tree';
21-
meta: MetaMenuItemTreeKind;
22-
}
23-
24-
export interface MetaMenuItemTreeKind extends MetaMenuItem {
25-
treeAlias: string;
26-
hideTreeRoot?: boolean;
27-
}
28-
29-
export interface ManifestMenuItemLinkKind extends ManifestMenuItem {
30-
type: 'menuItem';
31-
kind: 'link';
32-
meta: MetaMenuItemLinkKind;
33-
}
34-
35-
export interface MetaMenuItemLinkKind extends MetaMenuItem {
36-
href: string;
37-
}
38-
39-
export type UmbMenuItemExtensions = ManifestMenuItem | ManifestMenuItemTreeKind | ManifestMenuItemLinkKind;
40-
4118
declare global {
4219
interface UmbExtensionManifestMap {
43-
UmbMenuItemExtensions: UmbMenuItemExtensions;
20+
umbMenuItem: ManifestMenuItem;
4421
}
4522
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
export * from './tree-menu-item-default.element.js';
2+
export * from './types.js';

src/packages/core/tree/tree-menu-item-default/tree-menu-item-default.element.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
import type { ManifestMenuItemTreeKind } from './types.js';
12
import { html, nothing, customElement, property } from '@umbraco-cms/backoffice/external/lit';
23
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
34
import type { UmbExtensionManifestKind } from '@umbraco-cms/backoffice/extension-registry';
45
import { umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
5-
import type { ManifestMenuItemTreeKind, UmbMenuItemElement } from '@umbraco-cms/backoffice/menu';
6+
import type { UmbMenuItemElement } from '@umbraco-cms/backoffice/menu';
67

78
// TODO: Move to separate file:
89
const manifest: UmbExtensionManifestKind = {
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import type { ManifestMenuItem, MetaMenuItem } from '@umbraco-cms/backoffice/menu';
2+
3+
export interface ManifestMenuItemTreeKind extends ManifestMenuItem {
4+
type: 'menuItem';
5+
kind: 'tree';
6+
meta: MetaMenuItemTreeKind;
7+
}
8+
9+
export interface MetaMenuItemTreeKind extends MetaMenuItem {
10+
treeAlias: string;
11+
hideTreeRoot?: boolean;
12+
}
13+
14+
declare global {
15+
interface UmbExtensionManifestMap {
16+
umbTreeMenuItemKind: ManifestMenuItemTreeKind;
17+
}
18+
}

0 commit comments

Comments
 (0)