Skip to content

Commit fb470a9

Browse files
committed
chore: remove alerts
1 parent e7665ce commit fb470a9

File tree

6 files changed

+5
-14
lines changed

6 files changed

+5
-14
lines changed

src/packages/block/block-type/workspace/block-type-workspace.context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export class UmbBlockTypeWorkspaceContext<BlockTypeData extends UmbBlockTypeWith
128128
return 'block name content element type here...';
129129
}
130130
setName(name: string | undefined) {
131-
alert('You cannot set a name of a block-type.');
131+
console.warn('You cannot set a name of a block type.');
132132
}
133133

134134
async propertyValueByAlias<ReturnType = unknown>(propertyAlias: string) {

src/packages/documents/documents/entity-actions/permissions.action.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ export class UmbPermissionsEntityAction extends UmbEntityActionBase<never> {
77
}
88

99
async execute() {
10-
alert('Not implemented');
1110
throw new Error('Method not implemented.');
1211
}
1312
}

src/packages/media/media/modals/media-picker/components/media-picker-create-item.element.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,7 @@ export class UmbMediaPickerCreateItemElement extends UmbLitElement {
6969
this._allowedMediaTypes,
7070
(item) => item.unique,
7171
(item) =>
72-
html`<uui-menu-item
73-
label=${item.name}
74-
@click=${() =>
75-
alert(
76-
'TODO: Open workspace (create) from modal. You can drop the files into this modal for now.',
77-
)}>
72+
html`<uui-menu-item label=${item.name}>
7873
<umb-icon slot="icon" name=${item.icon ?? 'icon-circle-dotted'}></umb-icon>
7974
</uui-menu-item>`,
8075
)}

src/packages/media/media/property-editors/media-picker/components/input-rich-media/input-rich-media.element.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ export class UmbInputRichMediaElement extends UmbInputMediaElement {
3636
<uui-card-media
3737
name=${ifDefined(item.name === null ? undefined : item.name)}
3838
detail=${ifDefined(item.unique)}
39-
href="${this.editMediaPath}edit/${item.unique}"
40-
@open=${() => {
41-
alert('open media crops modal');
42-
}}>
39+
href="${this.editMediaPath}edit/${item.unique}">
4340
${item.url
4441
? html`<img src=${item.url} alt=${item.name} />`
4542
: html`<umb-icon name=${ifDefined(item.mediaType.icon)}></umb-icon>`}

src/packages/packages/package-section/views/installed/installed-packages-section-view-item.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class UmbInstalledPackagesSectionViewItemElement extends UmbLitElement {
7878
}
7979

8080
// TODO: add dedicated modal for package views, and register it in a manifest.
81-
alert('package view modal temporarily disabled. See comment in code.');
81+
throw new Error('package view modal temporarily disabled.');
8282
/*
8383
this._modalContext?.open(this, element, {
8484
data: { name: this.name, version: this.version },

src/packages/user/user/entity-bulk-actions/set-group/set-group.action.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ import { UmbEntityBulkActionBase } from '@umbraco-cms/backoffice/entity-bulk-act
33
export class UmbSetGroupUserEntityBulkAction extends UmbEntityBulkActionBase<object> {
44
async execute() {
55
//TODO: Implement
6-
alert('Bulk set group is not implemented yet');
6+
throw new Error('Bulk set group is not implemented yet');
77
}
88
}

0 commit comments

Comments
 (0)