Skip to content

Commit 33987e6

Browse files
committed
Services implementing interfaces
1 parent e45e25c commit 33987e6

13 files changed

+95
-27
lines changed

src/Umbraco.Cms.Integrations.Crm.Dynamics/Api/Management/Controllers/CheckOAuthConfigurationController.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,20 @@ namespace Umbraco.Cms.Integrations.Crm.Dynamics.Api.Management.Controllers
99
{
1010
public class CheckOAuthConfigurationController : FormsControllerBase
1111
{
12-
public CheckOAuthConfigurationController(IOptions<DynamicsSettings> options, DynamicsService dynamicsService, DynamicsConfigurationService dynamicsConfigurationService, DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory) : base(options, dynamicsService, dynamicsConfigurationService, authorizationImplementationFactory)
12+
public CheckOAuthConfigurationController(
13+
IOptions<DynamicsSettings> options,
14+
IDynamicsService dynamicsService,
15+
IDynamicsConfigurationStorage dynamicsConfigurationStorage,
16+
DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory)
17+
: base(options, dynamicsService, dynamicsConfigurationStorage, authorizationImplementationFactory)
1318
{
1419
}
1520

1621
[HttpGet("oauth-configuration")]
1722
[ProducesResponseType(typeof(OAuthConfigurationDto), StatusCodes.Status200OK)]
1823
public async Task<IActionResult> CheckOAuthConfiguration()
1924
{
20-
var oauthConfiguration = DynamicsConfigurationService.GetOAuthConfiguration();
25+
var oauthConfiguration = DynamicsConfigurationStorage.GetOAuthConfiguration();
2126

2227
if (oauthConfiguration == null) return Ok(new OAuthConfigurationDto { Message = string.Empty });
2328

src/Umbraco.Cms.Integrations.Crm.Dynamics/Api/Management/Controllers/FormsControllerBase.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ public class FormsControllerBase : DynamicsControllerBase
1616

1717
protected readonly IDynamicsAuthorizationService AuthorizationService;
1818

19-
protected readonly DynamicsService DynamicsService;
19+
protected readonly IDynamicsService DynamicsService;
2020

21-
protected readonly DynamicsConfigurationService DynamicsConfigurationService;
21+
protected readonly IDynamicsConfigurationStorage DynamicsConfigurationStorage;
2222

2323
public FormsControllerBase(IOptions<DynamicsSettings> options,
24-
DynamicsService dynamicsService,
25-
DynamicsConfigurationService dynamicsConfigurationService,
24+
IDynamicsService dynamicsService,
25+
IDynamicsConfigurationStorage dynamicsConfigurationStorage,
2626
AuthorizationImplementationFactory authorizationImplementationFactory)
2727
{
2828

@@ -32,7 +32,7 @@ public FormsControllerBase(IOptions<DynamicsSettings> options,
3232

3333
DynamicsService = dynamicsService;
3434

35-
DynamicsConfigurationService = dynamicsConfigurationService;
35+
DynamicsConfigurationStorage = dynamicsConfigurationStorage;
3636
}
3737
}
3838
}

src/Umbraco.Cms.Integrations.Crm.Dynamics/Api/Management/Controllers/GetAccessTokenController.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,12 @@ namespace Umbraco.Cms.Integrations.Crm.Dynamics.Api.Management.Controllers
99
{
1010
public class GetAccessTokenController : FormsControllerBase
1111
{
12-
public GetAccessTokenController(IOptions<DynamicsSettings> options, DynamicsService dynamicsService, DynamicsConfigurationService dynamicsConfigurationService, DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory) : base(options, dynamicsService, dynamicsConfigurationService, authorizationImplementationFactory)
12+
public GetAccessTokenController(
13+
IOptions<DynamicsSettings> options,
14+
IDynamicsService dynamicsService,
15+
IDynamicsConfigurationStorage dynamicsConfigurationStorage,
16+
DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory)
17+
: base(options, dynamicsService, dynamicsConfigurationStorage, authorizationImplementationFactory)
1318
{
1419
}
1520

src/Umbraco.Cms.Integrations.Crm.Dynamics/Api/Management/Controllers/GetAuthorizationUrlController.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@ namespace Umbraco.Cms.Integrations.Crm.Dynamics.Api.Management.Controllers
88
{
99
public class GetAuthorizationUrlController : FormsControllerBase
1010
{
11-
public GetAuthorizationUrlController(IOptions<DynamicsSettings> options, DynamicsService dynamicsService, DynamicsConfigurationService dynamicsConfigurationService, DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory) : base(options, dynamicsService, dynamicsConfigurationService, authorizationImplementationFactory)
11+
public GetAuthorizationUrlController(
12+
IOptions<DynamicsSettings> options,
13+
IDynamicsService dynamicsService,
14+
IDynamicsConfigurationStorage dynamicsConfigurationStorage,
15+
DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory)
16+
: base(options, dynamicsService, dynamicsConfigurationStorage, authorizationImplementationFactory)
1217
{
1318
}
1419

src/Umbraco.Cms.Integrations.Crm.Dynamics/Api/Management/Controllers/GetEmbedCodeController.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@ namespace Umbraco.Cms.Integrations.Crm.Dynamics.Api.Management.Controllers
88
{
99
public class GetEmbedCodeController : FormsControllerBase
1010
{
11-
public GetEmbedCodeController(IOptions<DynamicsSettings> options, DynamicsService dynamicsService, DynamicsConfigurationService dynamicsConfigurationService, DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory) : base(options, dynamicsService, dynamicsConfigurationService, authorizationImplementationFactory)
11+
public GetEmbedCodeController(
12+
IOptions<DynamicsSettings> options,
13+
IDynamicsService dynamicsService,
14+
IDynamicsConfigurationStorage dynamicsConfigurationStorage,
15+
DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory)
16+
: base(options, dynamicsService, dynamicsConfigurationStorage, authorizationImplementationFactory)
1217
{
1318
}
1419

src/Umbraco.Cms.Integrations.Crm.Dynamics/Api/Management/Controllers/GetFormsController.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,12 @@ namespace Umbraco.Cms.Integrations.Crm.Dynamics.Api.Management.Controllers
1010
{
1111
public class GetFormsController : FormsControllerBase
1212
{
13-
public GetFormsController(IOptions<DynamicsSettings> options, DynamicsService dynamicsService, DynamicsConfigurationService dynamicsConfigurationService, DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory) : base(options, dynamicsService, dynamicsConfigurationService, authorizationImplementationFactory)
13+
public GetFormsController(
14+
IOptions<DynamicsSettings> options,
15+
IDynamicsService dynamicsService,
16+
IDynamicsConfigurationStorage dynamicsConfigurationStorage,
17+
DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory)
18+
: base(options, dynamicsService, dynamicsConfigurationStorage, authorizationImplementationFactory)
1419
{
1520
}
1621

src/Umbraco.Cms.Integrations.Crm.Dynamics/Api/Management/Controllers/GetSystemUserFullNameController.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,17 @@ namespace Umbraco.Cms.Integrations.Crm.Dynamics.Api.Management.Controllers
88
{
99
public class GetSystemUserFullNameController : FormsControllerBase
1010
{
11-
public GetSystemUserFullNameController(IOptions<DynamicsSettings> options, DynamicsService dynamicsService, DynamicsConfigurationService dynamicsConfigurationService, DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory) : base(options, dynamicsService, dynamicsConfigurationService, authorizationImplementationFactory)
11+
public GetSystemUserFullNameController(
12+
IOptions<DynamicsSettings> options,
13+
IDynamicsService dynamicsService,
14+
IDynamicsConfigurationStorage dynamicsConfigurationStorage,
15+
DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory)
16+
: base(options, dynamicsService, dynamicsConfigurationStorage, authorizationImplementationFactory)
1217
{
1318
}
1419

1520
[HttpGet("system-user-fullname")]
1621
[ProducesResponseType(typeof(string), StatusCodes.Status200OK)]
17-
public IActionResult GetSystemUserFullName() => Ok(DynamicsConfigurationService.GetSystemUserFullName());
22+
public IActionResult GetSystemUserFullName() => Ok(DynamicsConfigurationStorage.GetSystemUserFullName());
1823
}
1924
}

src/Umbraco.Cms.Integrations.Crm.Dynamics/Api/Management/Controllers/RevokeAccessTokenController.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,17 @@ namespace Umbraco.Cms.Integrations.Crm.Dynamics.Api.Management.Controllers
88
{
99
public class RevokeAccessTokenController : FormsControllerBase
1010
{
11-
public RevokeAccessTokenController(IOptions<DynamicsSettings> options, DynamicsService dynamicsService, DynamicsConfigurationService dynamicsConfigurationService, DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory) : base(options, dynamicsService, dynamicsConfigurationService, authorizationImplementationFactory)
11+
public RevokeAccessTokenController(
12+
IOptions<DynamicsSettings> options,
13+
IDynamicsService dynamicsService,
14+
IDynamicsConfigurationStorage dynamicsConfigurationStorage,
15+
DynamicsComposer.AuthorizationImplementationFactory authorizationImplementationFactory)
16+
: base(options, dynamicsService, dynamicsConfigurationStorage, authorizationImplementationFactory)
1217
{
1318
}
1419

1520
[HttpDelete("revoke-access-token")]
1621
[ProducesResponseType(typeof(string), StatusCodes.Status200OK)]
17-
public IActionResult RevokeAccessToken() => Ok(DynamicsConfigurationService.Delete());
22+
public IActionResult RevokeAccessToken() => Ok(DynamicsConfigurationStorage.Delete());
1823
}
1924
}

src/Umbraco.Cms.Integrations.Crm.Dynamics/Services/AuthorizationService.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@ public class AuthorizationService : BaseAuthorizationService, IDynamicsAuthoriza
88
{
99
private readonly DynamicsOAuthSettings _oauthSettings;
1010

11-
public AuthorizationService(IOptions<DynamicsOAuthSettings> oauthOptions,
12-
DynamicsService dynamicsService, DynamicsConfigurationService dynamicsConfigurationService)
13-
: base(dynamicsService, dynamicsConfigurationService)
11+
public AuthorizationService(
12+
IOptions<DynamicsOAuthSettings> oauthOptions,
13+
IDynamicsService dynamicsService,
14+
IDynamicsConfigurationStorage dynamicsConfigurationStorage)
15+
: base(dynamicsService, dynamicsConfigurationStorage)
1416

1517
{
1618
_oauthSettings = oauthOptions.Value;

src/Umbraco.Cms.Integrations.Crm.Dynamics/Services/BaseAuthorizationService.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ public class BaseAuthorizationService
88
// Access to the client within the class is via ClientFactory(), allowing us to mock the responses in tests.
99
public static Func<HttpClient> ClientFactory = () => s_client;
1010

11-
protected readonly DynamicsService DynamicsService;
11+
protected readonly IDynamicsService DynamicsService;
1212

13-
protected readonly DynamicsConfigurationService DynamicsConfigurationService;
13+
protected readonly IDynamicsConfigurationStorage DynamicsConfigurationStorage;
1414

1515
protected const string DynamicsAuthorizationUrl = "https://login.microsoftonline.com/common/oauth2/v2.0/authorize" +
1616
"?client_id={0}" +
@@ -19,11 +19,11 @@ public class BaseAuthorizationService
1919
"&response_mode=query" +
2020
"&scope={2}";
2121

22-
public BaseAuthorizationService(DynamicsService dynamicsService, DynamicsConfigurationService dynamicsConfigurationService)
22+
public BaseAuthorizationService(IDynamicsService dynamicsService, IDynamicsConfigurationStorage dynamicsConfigurationStorage)
2323
{
2424
DynamicsService = dynamicsService;
2525

26-
DynamicsConfigurationService = dynamicsConfigurationService;
26+
DynamicsConfigurationStorage = dynamicsConfigurationStorage;
2727
}
2828

2929

0 commit comments

Comments
 (0)