Skip to content

Commit 4cbbf97

Browse files
authored
Merge pull request #189 from umbraco/feature/algolia-index-value-converter-include-property
Include IProperty with Algolia's index value converter
2 parents 3287f53 + e29ff93 commit 4cbbf97

8 files changed

+22
-13
lines changed

src/Umbraco.Cms.Integrations.Search.Algolia/Converters/IAlgoliaIndexValueConverter.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
1+
using Umbraco.Cms.Core.Models;
2+
3+
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
24
{
35
/// <summary>
46
/// Defines a custom index converter.
@@ -13,6 +15,6 @@ public interface IAlgoliaIndexValueConverter
1315
/// <summary>
1416
/// Parses the index values.
1517
/// </summary>
16-
object ParseIndexValues(IEnumerable<object> indexValues);
18+
object ParseIndexValues(IProperty property, IEnumerable<object> indexValues);
1719
}
1820
}

src/Umbraco.Cms.Integrations.Search.Algolia/Converters/UmbracoBooleanConverter.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
1+
using Umbraco.Cms.Core.Models;
2+
3+
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
24
{
35
public class UmbracoBooleanConverter : IAlgoliaIndexValueConverter
46
{
57
public string Name => Core.Constants.PropertyEditors.Aliases.Boolean;
68

7-
public object ParseIndexValues(IEnumerable<object> indexValues)
9+
public object ParseIndexValues(IProperty property, IEnumerable<object> indexValues)
810
{
911
if (indexValues != null && indexValues.Any())
1012
{

src/Umbraco.Cms.Integrations.Search.Algolia/Converters/UmbracoDecimalConverter.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
1+
using Umbraco.Cms.Core.Models;
2+
3+
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
24
{
35
public class UmbracoDecimalConverter : IAlgoliaIndexValueConverter
46
{
57
public string Name => Core.Constants.PropertyEditors.Aliases.Decimal;
68

7-
public object ParseIndexValues(IEnumerable<object> indexValues)
9+
public object ParseIndexValues(IProperty property, IEnumerable<object> indexValues)
810
{
911
if (indexValues != null && indexValues.Any())
1012
{

src/Umbraco.Cms.Integrations.Search.Algolia/Converters/UmbracoIntegerConverter.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
1+
using Umbraco.Cms.Core.Models;
2+
3+
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
24
{
35
public class UmbracoIntegerConverter : IAlgoliaIndexValueConverter
46
{
57
public string Name => Core.Constants.PropertyEditors.Aliases.Integer;
68

7-
public object ParseIndexValues(IEnumerable<object> indexValues)
9+
public object ParseIndexValues(IProperty property, IEnumerable<object> indexValues)
810
{
911
if (indexValues != null && indexValues.Any())
1012
{

src/Umbraco.Cms.Integrations.Search.Algolia/Converters/UmbracoMediaPickerConverter.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System.Text.Json;
2+
using Umbraco.Cms.Core.Models;
23
using Umbraco.Cms.Core.Services;
34

45
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
@@ -11,7 +12,7 @@ public class UmbracoMediaPickerConverter : IAlgoliaIndexValueConverter
1112

1213
public string Name => Core.Constants.PropertyEditors.Aliases.MediaPicker3;
1314

14-
public object ParseIndexValues(IEnumerable<object> indexValues)
15+
public object ParseIndexValues(IProperty property, IEnumerable<object> indexValues)
1516
{
1617
var list = new List<string>();
1718

src/Umbraco.Cms.Integrations.Search.Algolia/Converters/UmbracoTagsConverter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
using System.Text.Json;
1+
using Umbraco.Cms.Core.Models;
22

33
namespace Umbraco.Cms.Integrations.Search.Algolia.Converters
44
{
55
public class UmbracoTagsConverter : IAlgoliaIndexValueConverter
66
{
77
public string Name => Core.Constants.PropertyEditors.Aliases.Tags;
88

9-
public object ParseIndexValues(IEnumerable<object> indexValues)
9+
public object ParseIndexValues(IProperty property, IEnumerable<object> indexValues)
1010
{
1111
if (indexValues != null && indexValues.Any())
1212
{

src/Umbraco.Cms.Integrations.Search.Algolia/Services/AlgoliaSearchPropertyIndexValueFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public virtual KeyValuePair<string, object> GetValue(IProperty property, string
3737
var converter = _converterCollection.FirstOrDefault(p => p.Name == property.PropertyType.PropertyEditorAlias);
3838
if (converter != null)
3939
{
40-
var result = converter.ParseIndexValues(indexValue.Value);
40+
var result = converter.ParseIndexValues(property, indexValue.Value);
4141
return new KeyValuePair<string, object>(property.Alias, result);
4242
}
4343

src/Umbraco.Cms.Integrations.Search.Algolia/Umbraco.Cms.Integrations.Search.Algolia.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<PackageIconUrl></PackageIconUrl>
1414
<PackageProjectUrl>https://github.com/umbraco/Umbraco.Cms.Integrations/tree/main/src/Umbraco.Cms.Integrations.Search.Algolia</PackageProjectUrl>
1515
<RepositoryUrl>https://github.com/umbraco/Umbraco.Cms.Integrations</RepositoryUrl>
16-
<Version>2.1.4</Version>
16+
<Version>2.1.5</Version>
1717
<Authors>Umbraco HQ</Authors>
1818
<Company>Umbraco</Company>
1919
<PackageTags>Umbraco;Umbraco-Marketplace</PackageTags>

0 commit comments

Comments
 (0)