Remove try-catch blocks

Author: acoumb

src/Umbraco.Cms.Integrations.Search.Algolia/Api/Management/Controllers/BuildIndexController.cs

@@ -43,41 +43,33 @@ public BuildIndexController(
         [HttpPost("index/build")]
         public async Task<IActionResult> BuildIndex([FromBody] IndexConfiguration indexConfiguration)
         {
-            try
-            {
-                var index = IndexStorage.GetById(indexConfiguration.Id);
+            var index = IndexStorage.GetById(indexConfiguration.Id);
 
-                var payload = new List<Record>();
+            var payload = new List<Record>();
 
-                var indexContentData = JsonSerializer.Deserialize<IEnumerable<ContentTypeDto>>(index.SerializedData);
+            var indexContentData = JsonSerializer.Deserialize<IEnumerable<ContentTypeDto>>(index.SerializedData);
 
-                foreach (var contentDataItem in indexContentData)
-                {
-                    using var ctx = UmbracoContextFactory.EnsureUmbracoContext();
-                    var contentType = ctx.UmbracoContext.Content.GetContentType(contentDataItem.Alias);
-                    var contentItems = ContentService.GetPagedOfType(contentType.Id, 0, int.MaxValue, out _, null);
+            foreach (var contentDataItem in indexContentData)
+            {
+                using var ctx = UmbracoContextFactory.EnsureUmbracoContext();
+                var contentType = ctx.UmbracoContext.Content.GetContentType(contentDataItem.Alias);
+                var contentItems = ContentService.GetPagedOfType(contentType.Id, 0, int.MaxValue, out _, null);
 
-                    Logger.LogInformation("Building index for {ContentType} with {Count} items", contentDataItem.Alias, contentItems.Count());
+                Logger.LogInformation("Building index for {ContentType} with {Count} items", contentDataItem.Alias, contentItems.Count());
 
-                    foreach (var contentItem in contentItems.Where(p => !p.Trashed))
-                    {
-                        var record = new ContentRecordBuilder(UserService, UrlProvider, AlgoliaSearchPropertyIndexValueFactory, RecordBuilderFactory, UmbracoContextFactory)
-                            .BuildFromContent(contentItem, (p) => contentDataItem.Properties.Any(q => q.Alias == p.Alias))
-                            .Build();
+                foreach (var contentItem in contentItems.Where(p => !p.Trashed))
+                {
+                    var record = new ContentRecordBuilder(UserService, UrlProvider, AlgoliaSearchPropertyIndexValueFactory, RecordBuilderFactory, UmbracoContextFactory)
+                        .BuildFromContent(contentItem, (p) => contentDataItem.Properties.Any(q => q.Alias == p.Alias))
+                        .Build();
 
-                        payload.Add(record);
-                    }
+                    payload.Add(record);
                 }
+            }
 
-                var result = await IndexService.PushData(index.Name, payload);
+            var result = await IndexService.PushData(index.Name, payload);
 
-                return Ok(result);
-            }
-            catch (Exception ex)
-            {
-                Logger.LogError(ex, ex.Message);
-                throw;
-            }
+            return Ok(result);
         }
     }
 }

src/Umbraco.Cms.Integrations.Search.Algolia/Api/Management/Controllers/DeleteIndexController.cs

@@ -41,21 +41,13 @@ public DeleteIndexController(
         [HttpDelete("index/{id:int}")]
         public async Task<IActionResult> DeleteIndex(int id)
         {
-            try
-            {
-                var indexName = IndexStorage.GetById(id).Name;
+            var indexName = IndexStorage.GetById(id).Name;
 
-                IndexStorage.Delete(id);
+            IndexStorage.Delete(id);
 
-                await IndexService.DeleteIndex(indexName);
+            await IndexService.DeleteIndex(indexName);
 
-                return Ok(Result.Ok());
-            }
-            catch (Exception ex)
-            {
-                Logger.LogError(ex, ex.Message);
-                throw;
-            }
+            return Ok(Result.Ok());
         }
 
     }

src/Umbraco.Cms.Integrations.Search.Algolia/Api/Management/Controllers/SaveIndexController.cs

@@ -43,28 +43,20 @@ public SaveIndexController(
         [HttpPost("index")]
         public async Task<IActionResult> SaveIndex([FromBody] IndexConfiguration index)
         {
-            try
+            IndexStorage.AddOrUpdate(new AlgoliaIndex
             {
-                IndexStorage.AddOrUpdate(new AlgoliaIndex
-                {
-                    Id = index.Id,
-                    Name = index.Name,
-                    SerializedData = JsonSerializer.Serialize(index.ContentData
+                Id = index.Id,
+                Name = index.Name,
+                SerializedData = JsonSerializer.Serialize(index.ContentData
                         .Where(p => p.Selected && p.Properties.Any(q => q.Selected))),
-                    Date = DateTime.Now
-                });
+                Date = DateTime.Now
+            });
 
-                var result = await IndexService.IndexExists(index.Name)
-                    ? Result.Ok()
-                    : await IndexService.PushData(index.Name);
+            var result = await IndexService.IndexExists(index.Name)
+                ? Result.Ok()
+                : await IndexService.PushData(index.Name);
 
-                return Ok(result);
-            }
-            catch (Exception ex)
-            {
-                Logger.LogError(ex, ex.Message);
-                throw;
-            }
+            return Ok(result);
         }
     }
 }