Async and error handling.

Author: AndyButland

src/Umbraco.Cms.Integrations.Automation.Zapier/Controllers/ZapConfigController.cs

@@ -45,19 +45,13 @@ public IEnumerable<ContentTypeDto> GetContentTypes()
         }
 
         [HttpPost]
-        public string Add([FromBody] ContentConfigDto dto)
+        public async Task<string> Add([FromBody] ContentConfigDto dto)
         {
             var result = _zapConfigService.Add(dto);
             if (!string.IsNullOrEmpty(result)) return result;
 
-            var t = Task.Run(async () => await _zapierService.TriggerAsync(dto.WebHookUrl,
-                new Dictionary<string, string> {{Constants.Content.Name, dto.ContentTypeName}}));
-
-            result = t.Result;
-
-            if (!string.IsNullOrEmpty(result)) return result;
-
-            return result;
+            return await _zapierService.TriggerAsync(dto.WebHookUrl,
+                new Dictionary<string, string> { { Constants.Content.Name, dto.ContentTypeName } });
         } 
 
         [HttpGet]

src/Umbraco.Cms.Integrations.Automation.Zapier/Services/ZapierService.cs

@@ -15,9 +15,20 @@ public class ZapierService
 
         public async Task<string> TriggerAsync(string requestUri, Dictionary<string, string> content)
         {
-            var result = await ClientFactory().PostAsync(requestUri, new FormUrlEncodedContent(content));
+            try
+            {
+                var result = await ClientFactory().PostAsync(requestUri, new FormUrlEncodedContent(content));
 
-            return result.IsSuccessStatusCode ? string.Empty : result.ReasonPhrase;
+                return result.IsSuccessStatusCode ? string.Empty : result.ReasonPhrase;
+            }
+            catch (HttpRequestException)
+            {
+                return "Could not access the requested URL: " + requestUri;
+            }
+            catch (Exception)
+            {
+                throw;
+            }
         }
     }
 }