Skip to content

Commit c4df31d

Browse files
Use TargetFrameworkIdentifier to choose which incompatible views to remove
1 parent 35a3c50 commit c4df31d

File tree

2 files changed

+23
-9
lines changed

2 files changed

+23
-9
lines changed

src/Umbraco.Cms.Integrations.Commerce.Shopify/build/Umbraco.Cms.Integrations.Commerce.Shopify.targets

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,15 @@
66
<Target Name="CopyShopifyPropertyEditorAssets" BeforeTargets="BeforeBuild">
77
<ItemGroup>
88
<ShopifyPropertyEditorFiles Include="$(ShopifyPropertyEditorFilesPath)" />
9-
<ShopifyPropertyEditorFiles Condition="'$(TargetFramework)' != 'net472'" Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Commerce\Shopify\RenderV8\*.*" />
10-
<ShopifyPropertyEditorFiles Condition="'$(TargetFramework)' == 'net472'" Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Commerce\Shopify\Render\*.*" />
9+
<!-- Remove incompatible views based on TFM -->
10+
<Choose>
11+
<When Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
12+
<ShopifyPropertyEditorFiles Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Commerce\Shopify\Render\*.*" />
13+
</When>
14+
<Otherwise>
15+
<ShopifyPropertyEditorFiles Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Commerce\Shopify\RenderV8\*.*" />
16+
</Otherwise>
17+
</Choose>
1118
</ItemGroup>
1219
<Message Text="Copying Shopify Property Editor files: $(ShopifyPropertyEditorFilesPath) - #@(ShopifyPropertyEditorFiles->Count()) files" Importance="high" />
1320
<Copy SourceFiles="@(ShopifyPropertyEditorFiles)" DestinationFiles="@(ShopifyPropertyEditorFiles->'$(MSBuildProjectDirectory)\App_Plugins\UmbracoCms.Integrations\Commerce\Shopify\%(RecursiveDir)%(Filename)%(Extension)')" SkipUnchangedFiles="true" />
@@ -18,6 +25,6 @@
1825
<ShopifyPropertyEditorDir Include="$(MSBuildProjectDirectory)\App_Plugins\UmbracoCms.Integrations\Commerce\Shopify\" />
1926
</ItemGroup>
2027
<Message Text="Clear old Shopify Property Editor data" Importance="high" />
21-
<RemoveDir Directories="@(ShopifyPropertyEditorDir)" />
28+
<RemoveDir Directories="@(ShopifyPropertyEditorDir)" />
2229
</Target>
2330
</Project>

src/Umbraco.Cms.Integrations.Crm.Dynamics/build/Umbraco.Cms.Integrations.Crm.Dynamics.targets

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,25 @@
66
<Target Name="CopyDynamicsPropertyEditorAssets" BeforeTargets="BeforeBuild">
77
<ItemGroup>
88
<DynamicsPropertyEditorFiles Include="$(DynamicsPropertyEditorFilesPath)" />
9-
<DynamicsPropertyEditorFiles Condition="'$(TargetFramework)' != 'net472'" Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Crm\Dynamics\RenderV8\*.*" />
10-
<DynamicsPropertyEditorFiles Condition="'$(TargetFramework)' == 'net472'" Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Crm\Dynamics\Render\*.*" />
9+
<!-- Remove incompatible views based on TFM -->
10+
<Choose>
11+
<When Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
12+
<DynamicsPropertyEditorFiles Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Crm\Dynamics\Render\*.*" />
13+
</When>
14+
<Otherwise>
15+
<DynamicsPropertyEditorFiles Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Crm\Dynamics\RenderV8\*.*" />
16+
</Otherwise>
17+
</Choose>
1118
</ItemGroup>
1219
<Message Text="Copying Dynamics Property Editor files: $(DynamicsPropertyEditorFilesPath) - #@(DynamicsPropertyEditorFiles->Count()) files" Importance="high" />
1320
<Copy SourceFiles="@(DynamicsPropertyEditorFiles)" DestinationFiles="@(DynamicsPropertyEditorFiles->'$(MSBuildProjectDirectory)\App_Plugins\UmbracoCms.Integrations\Crm\Dynamics\%(RecursiveDir)%(Filename)%(Extension)')" SkipUnchangedFiles="true" />
1421
</Target>
15-
22+
1623
<Target Name="ClearDynamicsPropertyEditorAssets" BeforeTargets="Clean">
1724
<ItemGroup>
18-
<DynamicsPropertyEditorDir Include="$(MSBuildProjectDirectory)\App_Plugins\UmbracoCms\Crm\Dynamics\" />
25+
<DynamicsPropertyEditorDir Include="$(MSBuildProjectDirectory)\App_Plugins\UmbracoCms.Integrations\Crm\Dynamics\" />
1926
</ItemGroup>
20-
<Message Text="Clear old Dynamics Property Editor data" Importance="high" />
21-
<RemoveDir Directories="@(DynamicsPropertyEditorDir)" />
27+
<Message Text="Clear old Dynamics Property Editor data" Importance="high" />
28+
<RemoveDir Directories="@(DynamicsPropertyEditorDir)" />
2229
</Target>
2330
</Project>

0 commit comments

Comments
 (0)