PR feedback updates

Author: acoumb

src/Umbraco.Cms.Integrations.Automation.Zapier/Controllers/PollingController.cs

@@ -44,10 +44,8 @@ public PollingController(IContentService contentService, IUserValidationService
             _userValidationService = userValidationService;
         }
 
-        public List<Dictionary<string, string>> GetPublishedContent()
+        public List<Dictionary<string, string>> GetContent()
         {
-            var publishedContent = new List<Dictionary<string, string>>();
-
             string username = string.Empty;
             string password = string.Empty;
 
@@ -72,32 +70,18 @@ public List<Dictionary<string, string>> GetPublishedContent()
             var isAuthorized = _userValidationService.Validate(username, password, Options.UserGroup).GetAwaiter().GetResult();
             if (!isAuthorized) return null;
 
-            var rootNodes = _contentService.GetRootContent().Where(p => p.Published)
-                .OrderByDescending(p => p.PublishDate);
+            var root = _contentService.GetRootContent().Where(p => p.Published)
+                .OrderByDescending(p => p.PublishDate).FirstOrDefault();
 
-            foreach (var publishedContentRoot in rootNodes)
+            return new List<Dictionary<string, string>>
             {
-                publishedContent.Add(new Dictionary<string, string>
-                {
-                    { Constants.Content.Id, publishedContentRoot.Id.ToString() },
-                    { Constants.Content.Name, publishedContentRoot.Name },
-                    { Constants.Content.PublishDate, publishedContentRoot.PublishDate.Value.ToString() }
-                });
-
-                var ancestors = _contentService.GetAncestors(publishedContentRoot);
-                foreach (var ancestor in ancestors)
+                new Dictionary<string, string>
                 {
-                    publishedContent.Add(new Dictionary<string, string>
-                    {
-                        { Constants.Content.Id, ancestor.Id.ToString() },
-                        { Constants.Content.Name, ancestor.Name },
-                        { Constants.Content.PublishDate, ancestor.PublishDate.Value.ToString() }
-                    });
-
+                    {Constants.Content.Id, root?.Id.ToString()},
+                    {Constants.Content.Name, root?.Name},
+                    {Constants.Content.PublishDate, root?.PublishDate.ToString()}
                 }
-            }
-
-            return publishedContent;
+            };
         }
 
     }

src/Umbraco.Cms.Integrations.Automation.Zapier/Controllers/SubscriptionController.cs

@@ -73,9 +73,7 @@ public bool UpdatePreferences([FromBody] SubscriptionDto dto)
 
             var result = _zapConfigService.UpdatePreferences(dto.HookUrl, dto.Enable);
 
-            if (!string.IsNullOrEmpty(result)) return false;
-
-            return true;
+            return string.IsNullOrEmpty(result);
         }
     }
 }

src/Umbraco.Cms.Integrations.Automation.Zapier/Migrations/ZapContentConfigTable.cs

@@ -63,9 +63,11 @@ public class ZapContentConfig
             public int Id { get; set; }
 
             [Column("ContentTypeName")]
+            [Index(IndexTypes.NonClustered, Name = "IX_ZapContentConfig_ContentTypeName")]
             public string ContentTypeName { get; set; }
 
             [Column("WebHookUrl")] 
+            [Index(IndexTypes.NonClustered, Name = "IX_ZapContentConfig_WebHookUrl")]
             public string WebHookUrl { get; set; }
 
             [Column("IsEnabled")]