Update settings controller

Take authEventHandled property out of oauthStatus object scope

Author: acoumb

src/Umbraco.Cms.Integrations.Crm.Hubspot/App_Plugins/UmbracoCms.Integrations/Crm/Hubspot/js/settings.controller.js

@@ -4,10 +4,9 @@
 
     const oauthName = "OAuth";
 
-    vm.oauthSetup = {
-        authEventHandled : false
-    };
+    vm.oauthSetup = {};
     vm.status = {};
+    vm.authEventHandled = false;
 
     $scope.$on('formSubmitting', function () {
 
@@ -51,7 +50,7 @@
     vm.onRevokeToken = function() {
         umbracoCmsIntegrationsCrmHubspotResource.revokeAccessToken().then(function (response) {
             vm.oauthSetup.isConnected = false;
-            vm.oauthSetup.authEventHandled = false;
+            vm.authEventHandled = false;
 
             if(typeof $scope.connected === "undefined")
                 notificationsService.success("HubSpot Configuration", "OAuth connection revoked.");
@@ -66,11 +65,11 @@
 
         if (event.data.type === "hubspot:oauth:success") {
 
-            if (vm.oauthSetup.authEventHandled === true) return;
+            if (vm.authEventHandled === true) return;
 
             umbracoCmsIntegrationsCrmHubspotResource.getAccessToken(event.data.code).then(function (response) {
 
-                vm.oauthSetup.authEventHandled = true;
+                vm.authEventHandled = true;
 
                 if (response.startsWith("Error:")) {
                     if (typeof $scope.connected === "undefined")
@@ -115,4 +114,4 @@
 }
 
 angular.module("umbraco")
-    .controller("Umbraco.Cms.Integrations.Crm.Hubspot.SettingsController", settingsController);
+    .controller("Umbraco.Cms.Integrations.Crm.Hubspot.SettingsController", settingsController);