Prefer async render methods

mattbrailsford · mattbrailsford · commit 35f93eca6df0 · 2024-11-21T14:30:36.000Z
diff --git a/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutConfirmationPage.cshtml b/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutConfirmationPage.cshtml
@@ -19,4 +19,4 @@
     <p><a href="/" class="inline-block bg-@(themeColor) text-white px-4 py-4 rounded hover:bg-gray-900">@Umbraco.GetDictionaryValueOrDefault("UmbracoCommerceCheckout.Confirmation.ReturnToStore", "Return to store")</a></p>
 </div>
 
-@Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutOrderInfo.cshtml", currentOrder)
+@await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutOrderInfo.cshtml", currentOrder)
diff --git a/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutInformationPage.cshtml b/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutInformationPage.cshtml
@@ -142,5 +142,5 @@
     <h3 class="text-xl font-medium mb-4 mt-8">@Umbraco.GetDictionaryValueOrDefault("UmbracoCommerceCheckout.Information.Comments", "Comments")</h3>
     <textarea name="comments" placeholder="@Umbraco.GetDictionaryValueOrDefault("UmbracoCommerceCheckout.Information.EnterComments", "Enter comments here")" class="block placeholder-gray-700 border border-gray-300 rounded py-2 px-4 mb-2 w-full h-32">@(currentOrder.Properties["comments"])</textarea>
 
-    @Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")
+    @await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")
 }
diff --git a/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutLayout.cshtml b/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutLayout.cshtml
@@ -30,7 +30,7 @@
     <meta name="keywords" content="" />
     <meta name="robots" content="noindex, nofollow" />
     <link href="/App_Plugins/UmbracoCommerceCheckout/uccheckout.surface.css" rel="stylesheet">
-    @RenderSection("head", false)
+    @await RenderSectionAsync("head", false)
 </head>
 <body>
     <div class="relative text-sm">
@@ -81,7 +81,7 @@
                     }
                 </ul>
 
-                @RenderSection("aside", false)
+                @await RenderSectionAsync("aside", false)
 
                 <div class="flex w-full justify-between items-center">
                     <div class="">@Umbraco.GetDictionaryValueOrDefault("UmbracoCommerceCheckout.OrderSummary.Subtotal", "Subtotal")</div>
@@ -128,7 +128,7 @@
 
                 <div class="flex w-full justify-between items-center mt-2">
                     <div class="">@Umbraco.GetDictionaryValueOrDefault("UmbracoCommerceCheckout.OrderSummary.Tax", "Tax")</div>
-                    <div class="font-medium">@(currentOrder.TotalPrice.Value.FormattedAsync(x => x.Tax))</div>
+                    <div class="font-medium">@(await currentOrder.TotalPrice.Value.FormattedAsync(x => x.Tax))</div>
                 </div>
 
                 @foreach (var giftCardAdjustment in currentOrder.TransactionAmount.Adjustments.OfType<GiftCardAdjustment>())
@@ -230,7 +230,7 @@
 
     <script src="/App_Plugins/UmbracoCommerceCheckout/uccheckout.surface.js" defer async></script>
 
-    @RenderSection("foot", false)
+    @await RenderSectionAsync("foot", false)
 
-</body>
+    </body>
 </html>
diff --git a/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutPaymentMethodPage.cshtml b/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutPaymentMethodPage.cshtml
@@ -62,5 +62,5 @@
         <div class="border border-gray-300 rounded py-4 px-4 text-center">@Umbraco.GetDictionaryValueOrDefault("UmbracoCommerceCheckout.PaymentMethod.NothingToPay", "It looks like today is your lucky day, there is nothing for you to pay 🎉")</div>
     }
 
-    @Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")
+    @await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")
 }
diff --git a/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutReviewPage.cshtml b/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutReviewPage.cshtml
@@ -7,7 +7,7 @@
     var currentOrder = await UmbracoCommerceApi.Instance.GetCurrentOrderAsync(store.Id);
 }
 
-@Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutOrderInfo.cshtml", currentOrder)
+@await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutOrderInfo.cshtml", currentOrder)
 
 @using (await Html.BeginPaymentFormAsync(currentOrder))
 {
@@ -18,5 +18,5 @@
         </label>
     </div>
 
-    @Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")
+    @await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")
 }
diff --git a/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutShippingMethodPage.cshtml b/src/Umbraco.Commerce.Checkout/Views/UmbracoCommerceCheckout/UmbracoCommerceCheckoutShippingMethodPage.cshtml
@@ -102,5 +102,5 @@
 
     <input type="hidden" name="shippingOptionId" value="@(currentShippinOptionId)" />
 
-    @Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")
+    @await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")
 }

Original file line number	Diff line number	Diff line change
`@@ -142,5 +142,5 @@`
`142`	`142`	`<h3 class="text-xl font-medium mb-4 mt-8">@Umbraco.GetDictionaryValueOrDefault("UmbracoCommerceCheckout.Information.Comments", "Comments")</h3>`
`143`	`143`	`<textarea name="comments" placeholder="@Umbraco.GetDictionaryValueOrDefault("UmbracoCommerceCheckout.Information.EnterComments", "Enter comments here")" class="block placeholder-gray-700 border border-gray-300 rounded py-2 px-4 mb-2 w-full h-32">@(currentOrder.Properties["comments"])</textarea>`
`144`	`144`
`145`		`- @Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")`
	`145`	`+ @await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")`
`146`	`146`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,5 +62,5 @@`
`62`	`62`	`<div class="border border-gray-300 rounded py-4 px-4 text-center">@Umbraco.GetDictionaryValueOrDefault("UmbracoCommerceCheckout.PaymentMethod.NothingToPay", "It looks like today is your lucky day, there is nothing for you to pay 🎉")</div>`
`63`	`63`	`}`
`64`	`64`
`65`		`- @Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")`
	`65`	`+ @await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`var currentOrder = await UmbracoCommerceApi.Instance.GetCurrentOrderAsync(store.Id);`
`8`	`8`	`}`
`9`	`9`
`10`		`-@Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutOrderInfo.cshtml", currentOrder)`
	`10`	`+@await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutOrderInfo.cshtml", currentOrder)`
`11`	`11`
`12`	`12`	`@using (await Html.BeginPaymentFormAsync(currentOrder))`
`13`	`13`	`{`
`@@ -18,5 +18,5 @@`
`18`	`18`	`</label>`
`19`	`19`	`</div>`
`20`	`20`
`21`		`- @Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")`
	`21`	`+ @await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,5 +102,5 @@`
`102`	`102`
`103`	`103`	`<input type="hidden" name="shippingOptionId" value="@(currentShippinOptionId)" />`
`104`	`104`
`105`		`- @Html.Partial("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")`
	`105`	`+ @await Html.PartialAsync("~/Views/UmbracoCommerceCheckout/Partials/UmbracoCommerceCheckoutPrevNext.cshtml")`
`106`	`106`	`}`