Skip to content

Commit 37c2ce1

Browse files
switch to using ints instead of enums to be consistent
1 parent 1ef4f4b commit 37c2ce1

File tree

6 files changed

+12
-14
lines changed

6 files changed

+12
-14
lines changed

src/Umbraco.Commerce.Deploy/Artifacts/LocationArtifact.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public LocationArtifact(GuidUdi udi, GuidUdi storeUdi, IEnumerable<ArtifactDepen
1717
public string Region { get; set; }
1818
public string CountryIsoCode { get; set; }
1919
public string ZipCode { get; set; }
20-
public LocationType Type { get; set; }
20+
public int Type { get; set; }
2121
public int SortOrder { get; set; }
2222
}
2323
}

src/Umbraco.Commerce.Deploy/Artifacts/ShippingMethodArtifact.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
using Newtonsoft.Json.Linq;
44
using Umbraco.Cms.Core;
55
using Umbraco.Cms.Core.Deploy;
6-
using Umbraco.Commerce.Core.Models;
76

87
namespace Umbraco.Commerce.Deploy.Artifacts
98
{
@@ -20,7 +19,7 @@ public ShippingMethodArtifact(GuidUdi udi, GuidUdi storeUdi, IEnumerable<Artifac
2019
public IEnumerable<ServicePriceArtifact> Prices { get; set; }
2120
public string ImageId { get; set; }
2221

23-
public ShippingCalculationMode CalculationMode { get; set; }
22+
public int CalculationMode { get; set; }
2423
public JObject CalculationConfig { get; set; }
2524
public string ShippingProviderAlias { get; set; }
2625
public SortedDictionary<string, string> ShippingProviderSettings { get; set; }

src/Umbraco.Commerce.Deploy/Artifacts/StoreArtifact.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
using System.Collections.Generic;
33
using Umbraco.Cms.Core;
44
using Umbraco.Cms.Core.Deploy;
5-
using Umbraco.Commerce.Core.Models;
65
using Umbraco.Deploy.Infrastructure.Artifacts;
76

87
namespace Umbraco.Commerce.Deploy.Artifacts
@@ -25,7 +24,7 @@ public StoreArtifact(GuidUdi udi, IEnumerable<ArtifactDependency> dependencies =
2524

2625
public GuidUdi ErrorOrderStatusUdi { get; set; }
2726

28-
public MeasurementSystem MeasurementSystem { get; set; }
27+
public int MeasurementSystem { get; set; }
2928

3029
public bool PricesIncludeTax { get; set; }
3130

src/Umbraco.Commerce.Deploy/Connectors/ServiceConnectors/UmbracoCommerceLocationServiceConnector.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public override LocationArtifact GetArtifact(GuidUdi udi, LocationReadOnly entit
6363
Region = entity.Region,
6464
CountryIsoCode = entity.CountryIsoCode,
6565
ZipCode = entity.ZipCode,
66-
Type = entity.Type,
66+
Type = (int)entity.Type,
6767
SortOrder = entity.SortOrder
6868
};
6969
}
@@ -94,7 +94,7 @@ private void Pass2(ArtifactDeployState<LocationArtifact, LocationReadOnly> state
9494
var entity = state.Entity?.AsWritable(uow) ?? Location.Create(uow, artifact.Udi.Guid, artifact.StoreUdi.Guid, artifact.Alias, artifact.Name);
9595

9696
entity.SetName(artifact.Name, artifact.Alias)
97-
.SetType(artifact.Type)
97+
.SetType((LocationType)artifact.Type)
9898
.SetAddress(new Address(artifact.AddressLine1, artifact.AddressLine2, artifact.City, artifact.Region, artifact.CountryIsoCode, artifact.ZipCode))
9999
.SetSortOrder(artifact.SortOrder);
100100

src/Umbraco.Commerce.Deploy/Connectors/ServiceConnectors/UmbracoCommerceShippingMethodServiceConnector.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public override ShippingMethodArtifact GetArtifact(GuidUdi udi, ShippingMethodRe
6363
Alias = entity.Alias,
6464
Sku = entity.Sku,
6565
ImageId = entity.ImageId, // Could be a UDI?
66-
CalculationMode = entity.CalculationMode,
66+
CalculationMode = (int)entity.CalculationMode,
6767
ShippingProviderAlias = entity.ShippingProviderAlias,
6868
ShippingProviderSettings = new SortedDictionary<string, string>(entity.ShippingProviderSettings
6969
.Where(x => !StringExtensions.InvariantContains(_settingsAccessor.Settings.ShippingMethods.IgnoreSettings, x.Key)) // Ignore any settings that shouldn't be transfered
@@ -202,7 +202,7 @@ private void Pass2(ArtifactDeployState<ShippingMethodArtifact, ShippingMethodRea
202202
artifact.Udi.EnsureType(UmbracoCommerceConstants.UdiEntityType.ShippingMethod);
203203
artifact.StoreUdi.EnsureType(UmbracoCommerceConstants.UdiEntityType.Store);
204204

205-
var entity = state.Entity?.AsWritable(uow) ?? ShippingMethod.Create(uow, artifact.Udi.Guid, artifact.StoreUdi.Guid, artifact.Alias, artifact.Name, artifact.ShippingProviderAlias, artifact.CalculationMode);
205+
var entity = state.Entity?.AsWritable(uow) ?? ShippingMethod.Create(uow, artifact.Udi.Guid, artifact.StoreUdi.Guid, artifact.Alias, artifact.Name, artifact.ShippingProviderAlias, (ShippingCalculationMode)artifact.CalculationMode);
206206

207207
var settings = artifact.ShippingProviderSettings
208208
.Where(x => !StringExtensions.InvariantContains(_settingsAccessor.Settings.ShippingMethods.IgnoreSettings, x.Key)) // Ignore any settings that shouldn't be transfered
@@ -244,7 +244,7 @@ private void Pass4(ArtifactDeployState<ShippingMethodArtifact, ShippingMethodRea
244244
// Calculation config
245245
if (artifact.CalculationConfig != null)
246246
{
247-
if (artifact.CalculationMode == ShippingCalculationMode.Fixed)
247+
if (artifact.CalculationMode == (int)ShippingCalculationMode.Fixed)
248248
{
249249
var cfgArtifact = artifact.CalculationConfig.ToObject<FixedRateShippingCalculationConfigArtifact>();
250250
var prices = new List<ServicePrice>();
@@ -264,11 +264,11 @@ private void Pass4(ArtifactDeployState<ShippingMethodArtifact, ShippingMethodRea
264264

265265
entity.SetCalculationConfig(new FixedRateShippingCalculationConfig(prices));
266266
}
267-
else if (artifact.CalculationMode == ShippingCalculationMode.Dynamic)
267+
else if (artifact.CalculationMode == (int)ShippingCalculationMode.Dynamic)
268268
{
269269
entity.SetCalculationConfig(artifact.CalculationConfig.ToObject<DynamicRateShippingCalculationConfig>());
270270
}
271-
else if (artifact.CalculationMode == ShippingCalculationMode.Realtime)
271+
else if (artifact.CalculationMode == (int)ShippingCalculationMode.Realtime)
272272
{
273273
entity.SetCalculationConfig(artifact.CalculationConfig.ToObject<RealtimeRateShippingCalculationConfig>());
274274
}

src/Umbraco.Commerce.Deploy/Connectors/ServiceConnectors/UmbracoCommerceStoreServiceConnector.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public override StoreArtifact GetArtifact(GuidUdi udi, StoreReadOnly entity)
6161
{
6262
Name = entity.Name,
6363
Alias = entity.Alias,
64-
MeasurementSystem = entity.MeasurementSystem,
64+
MeasurementSystem = (int)entity.MeasurementSystem,
6565
PricesIncludeTax = entity.PricesIncludeTax,
6666
CookieTimeout = entity.CookieTimeout,
6767
CartNumberTemplate = entity.CartNumberTemplate,
@@ -255,7 +255,7 @@ private void Pass1(ArtifactDeployState<StoreArtifact, StoreReadOnly> state, IDep
255255

256256
#pragma warning disable CS0618 // SetOrderEditorConfig is obsolete
257257
entity.SetName(artifact.Name, artifact.Alias)
258-
.SetMeasurementSystem(artifact.MeasurementSystem)
258+
.SetMeasurementSystem((MeasurementSystem)artifact.MeasurementSystem)
259259
.SetPriceTaxInclusivity(artifact.PricesIncludeTax)
260260
.SetCartNumberTemplate(artifact.CartNumberTemplate)
261261
.SetOrderNumberTemplate(artifact.OrderNumberTemplate)

0 commit comments

Comments
 (0)