Unable to refund an order

[nickfrederiksen]

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

15.3.4

Bug summary

The ability to refund an order has been removed.

Specifics

When trying to refund an order, the refund-order form is correctly shown, but there is no way to actually refund it:

Looking through the page source, this seems why: The button has been commented out:

Note: We have not enabled partial refunds. There seems to be a lack of info on how to do it, so we skipped on that for now.

Steps to reproduce

Configure a payment method to allow refunds.

Finalize an order, using the above payment method.

Go to the order in Backoffice and click the "Refund Order".

Notice the missing "confirm" button.

Expected result / actual result

There should be a "confirm" button that refunds the order. That is, however, not the case.

Dependencies

No response

---

This item has been added to our backlog AB#52926

[umbracotrd]

@nickfrederiksen : thanks for reporting the issue. I'm bringing this up to our sprint discussion. The refund all button was commented out for a reason but looks like the alternative was missed out.

[umbracotrd]

15.3.5 with the fixes is out now 🚀. The refund all button is added to the Order Refund modal.

[nickfrederiksen]

Hi @umbracotrd

The button is now visible, and it also seems to do something. But it doesn't refund the order. It doesn't even call the overridden CancelPaymentAsync method on my custom provider.

I have set the 'CanRefundPayments' property to `true´.

The refund functionality used to work but was somehow broken when the "partial refunds" feature was introduced.

It is a bit of a critical issue for us to get this to work.

[mattbrailsford]

Refunding won't call the CancelPaymentAsync it should call the RefundPaymentAsync method. Cancelling is to cancel an authorized payment, refunding is used to refund a captured payment.

[umbracotrd]

@nickfrederiksen : like Matt said, CancelPaymentAsync has nothing to do with the old refund payment. I hope that it's just a typo.
Anyway, I've pushed the 15.3.6--preview.1+12036f6 to Umbraco nightly build that redirects to the old, deprecated IPaymentProvider.RefundPaymentAsync method when partial refund is disabled. Can you verify that it solves your issue?

[nickfrederiksen]

Hi @mattbrailsford @umbracotrd

It was a copy/paste error...

I meant to copy this:

public override async Task<ApiResult?> RefundPaymentAsync(PaymentProviderContext<EpayPaymentProviderSettings> context, PaymentProviderOrderRefundRequest refundRequest, CancellationToken cancellationToken = default)

This method is not being called in 15.3.5, it seems.

I implemented this method when the others became deprecated. But maybe this will only be called if CanPartiallyRefundPayments = true? Which is odd considering the method summary says it "Supports both partial refund and full refund.".

I haven't tried the nightly build yet, though.

[umbracotrd]

ok I see the problem now.

When a payment method has CanPartiallyRefundPayments = false, I redirect the refund request to the deprecated IPaymentProvider.RefundPaymentAsync, so that those who have not implemented the new IPaymentProvider.RefundPaymentAsync don't get the breaking change. This rule is enforced in the 15.3.6--preview.1+12036f6.

But doing that also means the new IPaymentProvider.RefundOrderPaymentAsync won't be called when CanPartiallyRefundPayments = false, regardless of whether it's implemented or not.

@mattbrailsford : let's discuss how we can solve this issue.

[nickfrederiksen]

@umbracotrd @mattbrailsford

I tried something, still using 15.3.5, and still have CanPartiallyRefundPayments = false. I can confirm the observations above.

Override every method on PaymentProviderBase<T> class related to refund.

There's no method called RefundOrderPaymentAsync in the IPaymentProvider interface or in the base-class.

The only method being called is the deprecated method Task<ApiResult?> RefundPaymentAsync(PaymentProviderContext context, CancellationToken cancellationToken = default). Which, in turn, calls the Task<ApiResult?> RefundPaymentAsync(PaymentProviderContext<T> context, CancellationToken cancellationToken = default) method. Also deprecated.

Changing CanPartiallyRefundPayments to true will trigger a call to Task<ApiResult?> RefundPaymentAsync(PaymentProviderContext<T> context, PaymentProviderOrderRefundRequest refundRequest, CancellationToken cancellationToken = default).

A workaround could be to just create a new instance of PaymentProviderOrderRefundRequest that contains all order lines and the order transaction amount as refund amount.