When using AddProduct with a productSnapshot, the prices are all zero.

[redmorello]

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

13.2.3

Bug summary

We are fetching our prices from an external service and have implemented this using a CustomProductAdapter & CustomProductSnapshot

We allow anyone to add a product to the cart, but only logged in users can see prices, so when the user first adds a product to the cart, we add using AddProduct, but the snapshot will have a zero price, as they are not logged in.

Once the user logs in, we are then trying to replace any orderlines that have a zero prices, with a product snapshot that has an actual price., as you can't directly modify the prices on the orderline.

We are doing this by looping over the order.OrderLines and removing any with a zero prices, copying the details into a new AddProduct call with a new snapshot. I can see the valid prices in the snapshot before we call AddProduct.

Once AddProduct is called, but before we call either:
_umbracoCommerceApi.SaveOrder(order);
uow.Complete();

I can see that the orderline has got a zero price again.

Specifics

No response

Steps to reproduce

I'm not sure you can!!

Expected result / actual result

I'd expect that AddProduct with a valid snapshot would have valid prices.

Dependencies

No response

[mattbrailsford]

The real bug here is that we shouldn't have made AddProduct public that accepts a product snapshot as really that's internal. Ultimately you can't call AddProduct with a product snapshot which doesn't come from the product adapter as internally further calls to the product adaptor take place.

I don't know if a better option might have been to just code the front end of the site to hide prices if the customer isn't logged in.

[redmorello]

We hide the zero price from the front end, and replace with a "Please login for prices".

Is it possible to add products to the cart "without" a price, instead of using zero based pricing ??

[mattbrailsford]

I'm not sure I understand the requirement to add products without a price. Why not add them with their price, but on the front end when showing the cart, just don't show the price. This way you never have to do anything "funky" with the order itself.

[redmorello]

We want people to be able to add products to their cart before logging in. Only when they login do we know more about them, and base their pricing on different parameters i.e country / discount etc

Originally with Vendr, I didn't think you could add a product without a price, hence why we went down the zero price route. We have since found out that people have been able to place zero total orders, if they add their products before logging in !!! When they consequently login, the price doesn't get changed.

I've just come across this in the docs:
builder.WithValidationEvent().RemoveHandler();

I'm not sure this is really a bug, more an architecture decision on our end.

[mattbrailsford]

You could also look at un thawing prices in an order. When a product is added to an order, it's price is frozen so that changes in the store don't affect the price of the item that is in the cart as store owners should honor the price of the product the person saw at the time of purchase. But you can thaw prices in an order and they should then recalculate.

If you check the IProductPriceFreezerService there are a bunch of methods on there to thaw the prices in an order. Maybe that could be used and called when a member logs in to force any current order to recalculate it's prices.

[redmorello]

Thanks @mattbrailsford I think that's exactly what we're after, just updating the prices once they've logged in.