Edit discount reward, resets/removes date range on save

[BenjaminLindgaard]

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

16.0.0-rc1

Bug summary

When editing a discount code, pressing the Rewards element and saves. The date range is removed on save

Specifics

Im using Umbraco.cms 16.0.0 cloud

Steps to reproduce

1. Setup the Umbraco demostore
2. Created a discount code with:
   Reward: "Orderline amount reward"
   Price type: Base Price
   Percentage: 10%
3. Select a date range and set start and expiry, hit save
4. Edit the newly saved discount (dont need to change anything), hit save
5. Result: date range is removed on save.

Gif on how to reproduce:

Expected result / actual result

Editing the discount shouldn't remove or reset the selected date range

Dependencies

No response

---

This item has been added to our backlog AB#54455

[mattbrailsford]

Hmm, I can't seem to replicate this. I can see from your recording that as soon as you hit save the dates clear, but in my local testing, this doesn't seem to happen. What does your save payload look like on submit and in return from the save (look in dev tools for the save request and look at the request payload and the response payload). Is the startDate and expiryDate populated in either or both? What timezone are you in?

[BenjaminLindgaard]

Hi Matt.
Here is the payload. Both expiryDate and startDate is set:

Payload:
{"alias":"test","blockFurtherDiscounts":false,"blockIfPreviousDiscounts":false,"codes":[],"expiryDate":"2025-07-26T07:22:00","id":"5b00c76c-e4e3-4bd2-8d1b-0197d4b565d8","isActive":false,"name":"test","rewards":[{"rewardProviderAlias":"orderLineAmountDiscountReward","settings":{"adjustmentType":"Percentage","amounts":{},"amountsIncludeTax":"0","percentage":"10","priceType":"BasePrice"}}],"rules":{"ruleProviderAlias":"groupDiscountRule","settings":{"matchType":"All"}},"sortOrder":1,"startDate":"2025-07-06T07:22:00","status":"Inactive","store":{"$type":"StoreRef","alias":"blendid","id":"c23cc1ca-37ca-4a70-a9d8-018bff89d4f2"},"type":"Automatic"}

Response:
{
"alias": "test",
"blockFurtherDiscounts": false,
"blockIfPreviousDiscounts": false,
"codes": [],
"expiryDate": "2025-07-26T07:22:00Z",
"id": "5b00c76c-e4e3-4bd2-8d1b-0197d4b565d8",
"isActive": false,
"name": "test",
"rewards": [
{
"rewardProviderAlias": "orderLineAmountDiscountReward",
"settings": {
"adjustmentType": "Percentage",
"amounts": {},
"amountsIncludeTax": "0",
"percentage": "10",
"priceType": "BasePrice"
}
}
],
"rules": {
"ruleProviderAlias": "groupDiscountRule",
"settings": {
"matchType": "All"
}
},
"sortOrder": 1,
"startDate": "2025-07-06T07:22:00Z",
"status": "Inactive",
"store": {
"$type": "StoreRef",
"alias": "blendid",
"id": "c23cc1ca-37ca-4a70-a9d8-018bff89d4f2"
},
"type": "Automatic"
}

My timezone is Denmark UTC +1

[BenjaminLindgaard]

Hi Matt.

I've tested some more and can tell that its every time i save a second time the date is cleared in the UI.
The date i still there in both response and payload.

I can see i also get this warning in my developer console tool:

index.js:15 The specified value "2025-07-26T08:12:00Z" does not conform to the required format. The format is "yyyy-MM-ddThh:mm" followed by optional ":ss" or ":ss.SSS".

[mattbrailsford]

Ok, great, that gives us something definitive to look into. Thanks for looking into it further. I'll get this scheduled to look at.

[skttl]

Might be related. I have a 16.0.0 with a custom discount reward provider looking like this

[DiscountRewardProvider("myMultipleTextstringProvider", Label = "Multiple Text")]
public class MultipleTextDiscountRewardProvider
    : DiscountRewardProviderBase<MultipleTextDiscountRewardProviderSettings>
{
    public MultipleTextDiscountRewardProvider(UmbracoCommerceContext ctx)
        : base(ctx) { }
}

public class MultipleTextDiscountRewardProviderSettings
{
    [DiscountRewardProviderSetting(
        Label = "Strings",
        SortOrder = 1,
        Key = "strings",
        EditorAlias = "Umbraco.MultipleTextstring",
        EditorConfig = "{\"min\":0,\"max\":0}"
    )]
    public IEnumerable<string> Strings { get; set; } = Enumerable.Empty<string>();
}

When adding the reward, I get the setting with the multiple textstring editor as expected:

When saving, the payload looks correct:

But the response is missing the values:

---

I also tried adding the most basic setting I could come up with:

    [DiscountRewardProviderSetting(Label = "String", Key = "string")]
    public string String { get; set; } = "";

This works as expected when saving.

[mattbrailsford]

@skttl I'm going to focus on the date issue and if that resolves your issue too, great, but if not, you'll need to raise that as a separate issue.

[skttl]

I think it might be the same issue, but lets see 🙂

[mattbrailsford]

So the date issue boils down to timezone issues. It looks like we aren't enforcing dates to return in UTC format from the Management API endpoints for UC and so for me, the dates are returned in the format "2025-07-26T08:12:00" where as for the OP there were returned in the format "2025-07-26T08:12:00Z" (with a Z). This then caused an issue with the uui-input datetime-local which we use for the date inputs. The input expects the date to be in a local format "2025-07-26T08:12:00" not UTC and so this is the error that was displaying.

I've now made an update to ensure that UC Management API endpoints ensure dates are always returned in UTC format for consistency and the front end for the discount + gift cards (the only places we use datetime-local input) to map these values from UCT to local before use and back again before persistence.

This fix will be in 16.1.1 and 15.3.10

@skttl unfortunately I don't think this will fix your issue.