Product Picker breaks when product has no price

[ProworksDevTeam]

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

15.3.4

Bug summary

When one or more products which match the searched criteria have an empty/null price, the product picker fails to display any results for selection.

Specifics

This has been reproduced in the following projects:

1. v15.3.4 Custom project based on the demo store
2. v16.0.0 Demo store

Steps to reproduce

Using a product with variants

1. Using the demo store 16.0.0 project
2. Go to Commerce Section -> Carts
3. Create a new cart
4. Click "Add a Product"
5. Enter "JT002" or "JT002-13" in search box and search
6. No results are displayed, despite JT002 and JT002-13 products existing (Jones Tea and Co -> Ever So English Breakfast) and the following error occurs in the browser console:

Using a product without variants

1. Using the demo store 16.0.0 project
2. Go to Commerce Section -> Carts
3. Create a new cart
4. Click "Add a Product"
5. Enter "GP002" in search box and search
6. Good and Proper - Breakfast Tea Set is found
7. Go to product GP002 (Good and Proper - Breakfast Tea Set) in content tree
8. Remove prices for both currencies and save
9. Return to Commerce Section -> Carts
10. Create a new cart (or edit existing)
11. Enter "GP002" in search box and search
12. No products are found and the following error occurs

Expected result / actual result

Expected to find products even though price is empty. This is especially true for products with variants as the parent product should not be purchasable and thus should not have a price. However, this prevents the user from being able to access the variants in the product picker.

Dependencies

No response

---

This item has been added to our backlog AB#54576

[mattbrailsford]

Thanks for reporting this @ProworksDevTeam and with such great detail 🙏

I think I have a good idea of what is going on so I'll get this scheduled in to take a look at.

[ProworksDevTeam]

Thanks for taking a look @mattbrailsford

[mattbrailsford]

This should now be fixed and will be in an upcoming 15.3.10 and 16.1.1 release.

I've updated it now so that it doesn't error if there is no price and instead shows the text "Unpriced". I've also set it to disable items that have no price (expect where they are a multi variant as you can click the parent unpriced item to get to the variant inner items that can be priced).