Multiple Textstrings not saving, when used for settings on providers

[skttl]

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

16.0.0

Bug summary

I have a 16.0.0 with a custom discount reward provider looking like this

[DiscountRewardProvider("myMultipleTextstringProvider", Label = "Multiple Text")]
public class MultipleTextDiscountRewardProvider
    : DiscountRewardProviderBase<MultipleTextDiscountRewardProviderSettings>
{
    public MultipleTextDiscountRewardProvider(UmbracoCommerceContext ctx)
        : base(ctx) { }
}

public class MultipleTextDiscountRewardProviderSettings
{
    [DiscountRewardProviderSetting(
        Label = "Strings",
        SortOrder = 1,
        Key = "strings",
        EditorAlias = "Umbraco.MultipleTextstring",
        EditorConfig = "{\"min\":0,\"max\":0}"
    )]
    public IEnumerable<string> Strings { get; set; } = Enumerable.Empty<string>();
}

When adding the reward, I get the setting with the multiple textstring editor as expected:

When saving, the payload looks correct:

But the response is missing the values:

---

I also tried adding the most basic setting I could come up with:

    [DiscountRewardProviderSetting(Label = "String", Key = "string")]
    public string String { get; set; } = "";

This works as expected when saving.

Specifics

No response

Steps to reproduce

• Create a reward/rule provider, with a setting using Multiple textstrings as mentioned above.
• Try to add a discount using the provider, add some text in the multiple text strings

Expected result / actual result

Expected to save the text put in the multiple textstrings, but didn't.

Dependencies

No response

---

This item has been added to our backlog AB#54663

[mattbrailsford]

I've managed to replicate this, and I do have a fix that is working for now, but I'm just seeing if there is a better way.

[mattbrailsford]

Fix will be in an upcoming 16.1.1 and 15.3.10 release

[skttl]

Works :) Although the value format seems to have changed, but thats probably my problem :)

[mattbrailsford]

Yea. It should be producing exactly what the CMS does now which is strongly typed.

A slight word of warning though that I'm not entirely sure how the CMS are converting a dynamically deserialized model that they don't know the type of to a typed model as used by the property editor. I'm currently having to do some recursive casting to make this work, but I've asked the CMS for details on how they are doing this.

[skttl]

I'll probably just remap the values manually, that seems to be the easiest solution :)