UmbracoStockSynchronizer ignores the stock property editor configuration

[BenWhite27]

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

16.2.1

Bug summary

The built-in UmbracoStockSynchronizer implementation only obtains the store from the content tree hierarchy, ignoring any configured Store on the Stock DataType definition.

Specifics

No response

Steps to reproduce

• Create a store, create a stock data type with that store configured, as well as necessary document types for testing.
• Create a content hierarchy that does not have a store property.
• Update the stock property within that hierarchy
• Notice that no record is created/updated in the database for that node.

Expected result / actual result

Given that the property has the configuration option I'd expect it would be used, and the stock get updated

... However, I'm aware that the stock database table doesn't actually need the store ID anyway, so maybe a better fix would be to remove the requirement for the store in the first place.

Dependencies

No response

---

This item has been added to our backlog AB#55160

[mattbrailsford]

Oooh, good spot. And I agree, it really should take the setting into account.

I can't recall everything the UmbracoStockSynchronizer does off the top of my head as to why it needs the store ID, but we can definitely investigate this while we look into it.

I'll add it to our backlog to review in the next sprint. In the meantime, if you need a workaround, you might just have to put a store picker on a parent document type for the synchronizer to find it.

[BenWhite27]

Cheers!
A little bit on my use case here..

We're a small business so can't afford the costs of a fully-fledged PIM solution, so I'm making use of Umbraco for PIM. We also plan to launch multiple e-commerce sites each with a different focus but a lot of cross over on the products.

Our plan is to have products under their own root node (without a template) in Umbraco, these documents will hold a good portion of the product data (simple description, images, specifications, relationships, etc.). And we'll be linking to these products from the Product Pages in the sites (inside the same Umbraco installation).

We don't have a specific need to track the stock against any one store and I'm not sure doing so would be a common requirement.

[mattbrailsford]

Ahhh, interesting use case.

If you aren't actually using stock then, you might be able to do something like this where you register your service dependencies

var savingDescriptor = new ServiceDescriptor(
    typeof(INotificationAsyncHandler<ContentSavingNotification>),
    typeof(SynchronizeUmbracoStockOnSaving),
    ServiceLifetime.Transient);
builder.Services.Remove(savingDescriptor);

var savedDescriptor = new ServiceDescriptor(
    typeof(INotificationAsyncHandler<ContentSavedNotification>),
    typeof(SynchronizeUmbracoStockOnSaved),
    ServiceLifetime.Transient);
builder.Services.Remove(savedDescriptor);

This should remove those event handlers entirely (unfortunately Umbraco doesn't provide an API for removing notification handlers so we need to do it via service descirptors)

Just make sure this happens after or inside your call to AddUmbracoCommerce

[BenWhite27]

Sorry I wasn't that clear🤦‍♂️, we do want to utilize stock, but don't need to have separate tracking of stock levels for each store.

I'll utilize your work around for the mean time.

Cheers!
Ben

[mattbrailsford]

A fix for this will be in an upcoming 16.3.0 release