Skip to content

CMS update to 16.3 now fails to boot - ILogger not registered in DI #773

@BenWhite27

Description

@BenWhite27

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

16.3.2

Bug summary

When using Umbraco Commerce 16.3.2 on CMS v16.3 with a Variants editor configured a startup exception is raised and Umbraco CMS fails to boot.

The root cause seems to be in a change in BlockEditorPropertyValueEditor:Line 33.

This is likely to be a bug in the CMS which I've raised here
umbraco/Umbraco-CMS#20531

But thought it might be important to highlight here as well.

Ultimately Commerce seems to be using the newly obsoleted constructor which forces the BlockEditorPropertyValueEditor to obtain an ILogger from the service provider. The problem is that it tries to obtain the non-generic implementation which doesn't get registered instead of ILogger<BlockEditorPropertyValueEditor>

Specifics

No response

Steps to reproduce

Install blank CMS + Umbraco Commerce
Configuring an Umbraco Commerce Variants editor data type will cause this error to occur in the background.
If you have an existing installation with a variants editor configured, then the whole CMS will fail to boot.

Expected result / actual result

No response

Dependencies

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions