Resolve Typescript incompatible types error for feedGeneratorId

Ben White · Ben White · commit ee05dbffe3f6 · 2025-05-27T09:48:24.000+01:00
diff --git a/src/Umbraco.Commerce.ProductFeeds.Client/frontend/src/workspaces/details/context.ts b/src/Umbraco.Commerce.ProductFeeds.Client/frontend/src/workspaces/details/context.ts
@@ -99,11 +99,15 @@ export class UcpfDetailsWorkspaceContext
 
     protected resetState(): void {
         super.resetState();
+
+        const availableFeedTypes = this.#feedTypes.getValue();
+
         this.#unique.setValue('');
         this.#model.setValue({
             feedDescription: '',
             storeId: this.#store!.id,
             feedName: '',
+            feedGeneratorId: availableFeedTypes.length > 0 ? availableFeedTypes[0] : '',
             feedRelativePath: '',
             productChildVariantTypeIds: [],
             productDocumentTypeIds: [],
diff --git a/src/Umbraco.Commerce.ProductFeeds.Client/frontend/src/workspaces/details/types.ts b/src/Umbraco.Commerce.ProductFeeds.Client/frontend/src/workspaces/details/types.ts
@@ -4,7 +4,7 @@ export type FeProductFeedSettingWriteModel = Omit<ProductFeedSettingWriteModel,
     id?: string
     propertyNameMappings: Array<FePropertyAndNodeMapDetails>
     productRootId?: string,
-    feedGeneratorId?: string
+    feedGeneratorId: string
 }
 
 export type FePropertyAndNodeMapDetails = PropertyAndNodeMapItem & {

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ export type FeProductFeedSettingWriteModel = Omit<ProductFeedSettingWriteModel,`
`4`	`4`	`id?: string`
`5`	`5`	`propertyNameMappings: Array<FePropertyAndNodeMapDetails>`
`6`	`6`	`productRootId?: string,`
`7`		`- feedGeneratorId?: string`
	`7`	`+ feedGeneratorId: string`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`export type FePropertyAndNodeMapDetails = PropertyAndNodeMapItem & {`