Merge pull request #9 from umbraco/temp-8

Error: No Property Type found with alias {key} on Content Type {contentType.Alias}

Author: mikkelhm

src/Umbraco.Deploy.Contrib.Connectors/ValueConnectors/InnerContentConnector.cs

@@ -5,6 +5,7 @@
 using Newtonsoft.Json.Linq;
 using Umbraco.Core;
 using Umbraco.Core.Deploy;
+using Umbraco.Core.Logging;
 using Umbraco.Core.Models;
 using Umbraco.Core.Services;
 using Umbraco.Deploy.ValueConnectors;
@@ -84,7 +85,10 @@ public string GetValue(Property property, ICollection<ArtifactDependency> depend
                     var propertyType = contentType.CompositionPropertyTypes.FirstOrDefault(x => x.Alias == key);
 
                     if (propertyType == null)
-                        throw new NullReferenceException($"No Property Type found with alias {key} on Content Type {contentType.Alias}");
+                    {
+                        LogHelper.Debug<InnerContentConnector>($"No Property Type found with alias {key} on Content Type {contentType.Alias}");
+                        continue;
+                    }
 
                     // throws if not found - no need for a null check
                     var propValueConnector = ValueConnectors.Get(propertyType);
@@ -177,7 +181,10 @@ public void SetValue(IContentBase content, string alias, string value)
                     var propertyType = contentType.CompositionPropertyTypes.FirstOrDefault(x => x.Alias == key);
 
                     if (propertyType == null)
-                        throw new NullReferenceException($"No Property Type found with alias {key} on Content Type {contentType.Alias}");
+                    {
+                        LogHelper.Debug<InnerContentConnector>($"No Property Type found with alias {key} on Content Type {contentType.Alias}");
+                        continue;
+                    }
 
                     // throws if not found - no need for a null check
                     var propValueConnector = ValueConnectors.Get(propertyType);

src/Umbraco.Deploy.Contrib.Connectors/ValueConnectors/NestedContentValueConnector.cs

@@ -5,6 +5,7 @@
 using Newtonsoft.Json.Linq;
 using Umbraco.Core;
 using Umbraco.Core.Deploy;
+using Umbraco.Core.Logging;
 using Umbraco.Core.Models;
 using Umbraco.Core.Services;
 using Umbraco.Deploy.ValueConnectors;
@@ -91,7 +92,10 @@ public string GetValue(Property property, ICollection<ArtifactDependency> depend
                     var propertyType = contentType.CompositionPropertyTypes.FirstOrDefault(x => x.Alias == key);
 
                     if (propertyType == null)
-                        throw new NullReferenceException($"No Property Type found with alias {key} on Content Type {contentType.Alias}");
+                    {
+                        LogHelper.Debug<NestedContentValueConnector>($"No Property Type found with alias {key} on Content Type {contentType.Alias}");
+                        continue;
+                    }
 
                     // throws if not found - no need for a null check
                     var propValueConnector = ValueConnectors.Get(propertyType);
@@ -193,7 +197,10 @@ public void SetValue(IContentBase content, string alias, string value)
                     var propertyType = contentType.CompositionPropertyTypes.FirstOrDefault(x => x.Alias == key);
 
                     if (propertyType == null)
-                        throw new NullReferenceException($"No Property Type found with alias {key} on Content Type {contentType.Alias}");
+                    {
+                        LogHelper.Debug<NestedContentValueConnector>($"No Property Type found with alias {key} on Content Type {contentType.Alias}");
+                        continue;
+                    }
 
                     // throws if not found - no need for a null check
                     var propValueConnector = ValueConnectors.Get(propertyType);