Fix migrating legacy RTE, textbox/area and Multi URL Picker configuration

Author: ronaldbarendse

src/Umbraco.Deploy.Contrib/Migrators/Legacy/DataType/MultiUrlPickerReplaceDataTypeArtifactMigratorBase.cs

@@ -1,17 +1,17 @@
+using System.Collections.Generic;
 using Umbraco.Cms.Core;
 using Umbraco.Cms.Core.PropertyEditors;
 using Umbraco.Cms.Core.Semver;
 using Umbraco.Cms.Core.Serialization;
 using Umbraco.Deploy.Core;
 using Umbraco.Deploy.Infrastructure.Artifacts;
-using Umbraco.Deploy.Infrastructure.Migrators;
 
 namespace Umbraco.Deploy.Contrib.Migrators.Legacy;
 
 /// <summary>
 /// Migrates the <see cref="DataTypeArtifact" /> to replace the editor alias with <see cref="Constants.PropertyEditors.Aliases.MultiUrlPicker" />.
 /// </summary>
-public abstract class MultiUrlPickerReplaceDataTypeArtifactMigratorBase : ReplaceDataTypeArtifactMigratorBase
+public abstract class MultiUrlPickerReplaceDataTypeArtifactMigratorBase : LegacyReplaceDataTypeArtifactMigratorBase
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="MultiUrlPickerReplaceDataTypeArtifactMigratorBase" /> class.
@@ -22,4 +22,12 @@ public abstract class MultiUrlPickerReplaceDataTypeArtifactMigratorBase : Replac
     protected MultiUrlPickerReplaceDataTypeArtifactMigratorBase(string fromEditorAlias, PropertyEditorCollection propertyEditors, IConfigurationEditorJsonSerializer configurationEditorJsonSerializer)
         : base(fromEditorAlias, Constants.PropertyEditors.Aliases.MultiUrlPicker, DeployConstants.PropertyEditors.UiAliases.MultiUrlPicker, propertyEditors, configurationEditorJsonSerializer)
         => MaxVersion = new SemVersion(3, 0, 0);
+
+    /// <inheritdoc />
+    protected override IDictionary<string, object>? MigrateConfiguration(IDictionary<string, object> configuration)
+    {
+        ReplaceIntegerWithBoolean(ref configuration, Constants.DataTypes.ReservedPreValueKeys.IgnoreUserStartNodes);
+
+        return configuration;
+    }
 }

src/Umbraco.Deploy.Contrib/Migrators/Legacy/DataType/RelatedLinks2DataTypeArtifactMigrator.cs

@@ -1,4 +1,3 @@
-using System.Collections.Generic;
 using Umbraco.Cms.Core;
 using Umbraco.Cms.Core.PropertyEditors;
 using Umbraco.Cms.Core.Serialization;
@@ -21,8 +20,4 @@ public class RelatedLinks2DataTypeArtifactMigrator : MultiUrlPickerReplaceDataTy
     public RelatedLinks2DataTypeArtifactMigrator(PropertyEditorCollection propertyEditors, IConfigurationEditorJsonSerializer configurationEditorJsonSerializer)
         : base(FromEditorAlias, propertyEditors, configurationEditorJsonSerializer)
     { }
-
-    /// <inheritdoc />
-    protected override IDictionary<string, object>? MigrateConfiguration(IDictionary<string, object> configuration)
-        => configuration;
 }

src/Umbraco.Deploy.Contrib/Migrators/Legacy/DataType/RelatedLinksDataTypeArtifactMigrator.cs

@@ -1,4 +1,3 @@
-using System.Collections.Generic;
 using Umbraco.Cms.Core;
 using Umbraco.Cms.Core.PropertyEditors;
 using Umbraco.Cms.Core.Serialization;
@@ -21,8 +20,4 @@ public class RelatedLinksDataTypeArtifactMigrator : MultiUrlPickerReplaceDataTyp
     public RelatedLinksDataTypeArtifactMigrator(PropertyEditorCollection propertyEditors, IConfigurationEditorJsonSerializer configurationEditorJsonSerializer)
         : base(FromEditorAlias, propertyEditors, configurationEditorJsonSerializer)
     { }
-
-    /// <inheritdoc />
-    protected override IDictionary<string, object>? MigrateConfiguration(IDictionary<string, object> configuration)
-        => configuration;
 }

src/Umbraco.Deploy.Contrib/Migrators/Legacy/DataType/TextboxDataTypeArtifactMigrator.cs

@@ -5,14 +5,13 @@
 using Umbraco.Cms.Core.Serialization;
 using Umbraco.Deploy.Core;
 using Umbraco.Deploy.Infrastructure.Artifacts;
-using Umbraco.Deploy.Infrastructure.Migrators;
 
 namespace Umbraco.Deploy.Contrib.Migrators.Legacy;
 
 /// <summary>
 /// Migrates the <see cref="DataTypeArtifact" /> to replace the <see cref="FromEditorAlias" /> editor with <see cref="Constants.PropertyEditors.Aliases.TextBox" />.
 /// </summary>
-public class TextboxDataTypeArtifactMigrator : ReplaceDataTypeArtifactMigratorBase
+public class TextboxDataTypeArtifactMigrator : LegacyReplaceDataTypeArtifactMigratorBase
 {
     private const string FromEditorAlias = "Umbraco.Textbox";
 
@@ -27,5 +26,10 @@ public TextboxDataTypeArtifactMigrator(PropertyEditorCollection propertyEditors,
 
     /// <inheritdoc />
     protected override IDictionary<string, object>? MigrateConfiguration(IDictionary<string, object> configuration)
-        => configuration;
+    {
+        ReplaceStringWithInteger(ref configuration, "maxChars");
+        ReplaceStringWithInteger(ref configuration, "rows");
+
+        return configuration;
+    }
 }

src/Umbraco.Deploy.Contrib/Migrators/Legacy/DataType/TextboxMultipleDataTypeArtifactMigrator.cs

@@ -5,14 +5,13 @@
 using Umbraco.Cms.Core.Serialization;
 using Umbraco.Deploy.Core;
 using Umbraco.Deploy.Infrastructure.Artifacts;
-using Umbraco.Deploy.Infrastructure.Migrators;
 
 namespace Umbraco.Deploy.Contrib.Migrators.Legacy;
 
 /// <summary>
 /// Migrates the <see cref="DataTypeArtifact" /> to replace the <see cref="FromEditorAlias" /> editor with <see cref="Constants.PropertyEditors.Aliases.TextArea" />.
 /// </summary>
-public class TextboxMultipleDataTypeArtifactMigrator : ReplaceDataTypeArtifactMigratorBase
+public class TextboxMultipleDataTypeArtifactMigrator : LegacyReplaceDataTypeArtifactMigratorBase
 {
     private const string FromEditorAlias = "Umbraco.TextboxMultiple";
 
@@ -27,5 +26,10 @@ public TextboxMultipleDataTypeArtifactMigrator(PropertyEditorCollection property
 
     /// <inheritdoc />
     protected override IDictionary<string, object>? MigrateConfiguration(IDictionary<string, object> configuration)
-        => configuration;
+    {
+        ReplaceStringWithInteger(ref configuration, "maxChars");
+        ReplaceStringWithInteger(ref configuration, "rows");
+
+        return configuration;
+    }
 }

src/Umbraco.Deploy.Contrib/Migrators/Legacy/DataType/TinyMCEv3DataTypeArtifactMigrator.cs

@@ -1,18 +1,19 @@
 using System.Collections.Generic;
+using System.Linq;
 using Umbraco.Cms.Core;
 using Umbraco.Cms.Core.PropertyEditors;
 using Umbraco.Cms.Core.Semver;
 using Umbraco.Cms.Core.Serialization;
 using Umbraco.Deploy.Core;
 using Umbraco.Deploy.Infrastructure.Artifacts;
-using Umbraco.Deploy.Infrastructure.Migrators;
+using Umbraco.Extensions;
 
 namespace Umbraco.Deploy.Contrib.Migrators.Legacy;
 
 /// <summary>
 /// Migrates the <see cref="DataTypeArtifact" /> to replace the <see cref="FromEditorAlias" /> editor with <see cref="Constants.PropertyEditors.Aliases.RichText" />.
 /// </summary>
-public class TinyMCEv3DataTypeArtifactMigrator : ReplaceDataTypeArtifactMigratorBase
+public class TinyMCEv3DataTypeArtifactMigrator : LegacyReplaceDataTypeArtifactMigratorBase
 {
     private const string FromEditorAlias = "Umbraco.TinyMCEv3";
 
@@ -27,5 +28,79 @@ public TinyMCEv3DataTypeArtifactMigrator(PropertyEditorCollection propertyEditor
 
     /// <inheritdoc />
     protected override IDictionary<string, object>? MigrateConfiguration(IDictionary<string, object> configuration)
-        => configuration;
+    {
+        ReplaceUdiWithGuid(ref configuration, "mediaParentId");
+        ReplaceRichTextEditor(ref configuration);
+        ReplaceIntegerWithBoolean(ref configuration, Constants.DataTypes.ReservedPreValueKeys.IgnoreUserStartNodes);
+        configuration.TryAdd("toolbar", new[]
+        {
+            "style",
+            "bold",
+            "italic",
+            "alignleft",
+            "aligncenter",
+            "alignright",
+            "bullist",
+            "numlist",
+            "outdent",
+            "indent",
+            "link",
+            "sourcecode",
+            "umbmediapicker",
+            "umbembeddialog"
+        });
+        configuration.TryAdd("mode", "Classic");
+        configuration.TryAdd("maxImageSize", 500);
+        configuration.TryAdd("overlaySize", "small");
+
+        return configuration;
+    }
+
+    private void ReplaceRichTextEditor(ref IDictionary<string, object> configuration)
+    {
+        if (TryDeserialize(ref configuration, "editor", out RichTextEditorConfiguration? richTextEditorConfiguration))
+        {
+            if (richTextEditorConfiguration.Toolbar is { Length: > 0 })
+            {
+                // Replace ace with sourcecode
+                configuration["toolbar"] = richTextEditorConfiguration.Toolbar.Select(x => x == "ace" ? "sourcecode" : x).ToArray();
+            }
+
+            if (richTextEditorConfiguration.Stylesheets is { Length: > 0 })
+            {
+                configuration["stylesheets"] = richTextEditorConfiguration.Stylesheets;
+            }
+
+            if (string.IsNullOrEmpty(richTextEditorConfiguration.Mode) is false)
+            {
+                configuration["mode"] = richTextEditorConfiguration.Mode.ToFirstUpperInvariant();
+            }
+
+            if (richTextEditorConfiguration.MaxImageSize is not null)
+            {
+                configuration["maxImageSize"] = richTextEditorConfiguration.MaxImageSize;
+            }
+
+            if (richTextEditorConfiguration.Dimensions is not null)
+            {
+                configuration["dimensions"] = richTextEditorConfiguration.Dimensions;
+            }
+
+            configuration.Remove("editor");
+        }
+    }
+
+    private sealed class RichTextEditorConfiguration
+    {
+        public string[]? Toolbar { get; set; }
+        public string[]? Stylesheets { get; set; }
+        public int? MaxImageSize { get; set; }
+        public string? Mode { get; set; }
+        public EditorDimensions? Dimensions { get; set; }
+        public sealed class EditorDimensions
+        {
+            public int? Width { get; set; }
+            public int? Height { get; set; }
+        }
+    }
 }