Optimised existence check in multi URL picker.

AndyButland · AndyButland · commit 784baa2eafca · 2022-05-11T13:59:05.000+02:00
diff --git a/src/Umbraco.Deploy.Contrib.Connectors/ValueConnectors/MultiUrlPickerValueConnector.cs b/src/Umbraco.Deploy.Contrib.Connectors/ValueConnectors/MultiUrlPickerValueConnector.cs
@@ -92,9 +92,11 @@ public string ToArtifact(object value, PropertyType propertyType, ICollection<Ar
                     }
                     else if (TryParseJTokenAttr(link, "udi", out guidUdi))
                     {
-                        var entity = _entityService.Get(guidUdi.Guid, Constants.UdiEntityType.ToUmbracoObjectType(guidUdi.EntityType));
-                        if (entity == null)
+                        var entityExists = _entityService.Exists(guidUdi.Guid);
+                        if (!entityExists)
+                        {
                             continue;
+                        }
 
                         // Add the artifact dependency
                         dependencies.Add(new ArtifactDependency(guidUdi, false, ArtifactDependencyMode.Exist));

Original file line number	Diff line number	Diff line change
`@@ -92,9 +92,11 @@ public string ToArtifact(object value, PropertyType propertyType, ICollection<Ar`
`92`	`92`	`}`
`93`	`93`	`else if (TryParseJTokenAttr(link, "udi", out guidUdi))`
`94`	`94`	`{`
`95`		`- var entity = _entityService.Get(guidUdi.Guid, Constants.UdiEntityType.ToUmbracoObjectType(guidUdi.EntityType));`
`96`		`- if (entity == null)`
	`95`	`+ var entityExists = _entityService.Exists(guidUdi.Guid);`
	`96`	`+ if (!entityExists)`
	`97`	`+ {`
`97`	`98`	`continue;`
	`99`	`+ }`
`98`	`100`
`99`	`101`	`// Add the artifact dependency`
`100`	`102`	`dependencies.Add(new ArtifactDependency(guidUdi, false, ArtifactDependencyMode.Exist));`