Merge pull request #33 from umbraco/bug/deploying-vorto-data-without-dtd

Deploying old vorto data

Author: ksuvec

src/Umbraco.Deploy.Contrib.Connectors/ValueConnectors/VortoValueConnector.cs

@@ -5,6 +5,7 @@
 using Newtonsoft.Json.Linq;
 using Umbraco.Core;
 using Umbraco.Core.Deploy;
+using Umbraco.Core.Logging;
 using Umbraco.Core.Models;
 using Umbraco.Core.Services;
 using Umbraco.Deploy.ValueConnectors;
@@ -64,6 +65,13 @@ public string GetValue(Property property, ICollection<ArtifactDependency> depend
             if (vortoValue?.Values?.ValuePairs == null)
                 return null;
 
+            // old versions of Vorto doesn't seem to store a DtdGuid - in those cases we just deploy the value as it is without any further handling.
+            if (string.IsNullOrWhiteSpace(vortoValue.DtdGuid))
+            {
+                LogHelper.Debug<VortoValueConnector>($"No datatype definition defined inside the Vorto property: {property.Alias} - are you using an old version of Vorto? - data value will be deployed as it is.");
+                return value;
+            }
+
             // get the Vorto datatype
             var vortoDataType = _dataTypeService.GetDataTypeDefinitionById(Guid.Parse(vortoValue.DtdGuid));
 
@@ -135,6 +143,14 @@ public void SetValue(IContentBase content, string alias, string value)
             if (vortoValue == null)
                 return;
 
+            // old versions of Vorto doesn't seem to store a DtdGuid - in those cases we just deploy the value as it is without any further handling.
+            if (string.IsNullOrWhiteSpace(vortoValue.DtdGuid))
+            {
+                LogHelper.Debug<VortoValueConnector>($"No datatype definition defined inside the Vorto property: {alias} - are you using an old version of Vorto? - data value will be deployed as it is.");
+                content.SetValue(alias, value);
+                return;
+            }
+
             // getting the wrapped datatype via the Vorto datatype
             var vortoDataType = _dataTypeService.GetDataTypeDefinitionById(Guid.Parse(vortoValue.DtdGuid));
             var vortoDataTypePrevalueJson = _dataTypeService.GetPreValuesCollectionByDataTypeId(vortoDataType.Id).FormatAsDictionary().FirstOrDefault(x => x.Key == "dataType").Value.Value;