Migrate prevalues of legacy dropdown editors

Author: ronaldbarendse

src/Umbraco.Deploy.Contrib/Extensions/PropertyTypeMigratorCollectionBuilderExtensions.cs

@@ -15,6 +15,10 @@ public static PropertyTypeMigratorCollectionBuilder AddLegacyMigrators(this Prop
         => propertyTypeMigratorCollectionBuilder
             // Pre-values to a single value or JSON array
             .Append<CheckBoxListPropertyTypeMigrator>()
+            .Append<DropDownPropertyTypeMigrator>()
             .Append<DropDownListFlexiblePropertyTypeMigrator>()
+            .Append<DropdownlistMultiplePublishKeysPropertyTypeMigrator>()
+            .Append<DropdownlistPublishingKeysPropertyTypeMigrator>()
+            .Append<DropDownMultiplePropertyTypeMigrator>()
             .Append<RadioButtonListPropertyTypeMigrator>();
 }

src/Umbraco.Deploy.Contrib/Migrators/Legacy/Content/DropDownMultiplePropertyTypeMigrator.cs

@@ -0,0 +1,23 @@
+using Umbraco.Cms.Core;
+using Umbraco.Cms.Core.Serialization;
+
+namespace Umbraco.Deploy.Contrib.Migrators.Legacy;
+
+/// <summary>
+/// Migrates the property value from the legacy <see cref="FromEditorAlias" /> editor containing prevalues (seperated by <see cref="PrevaluePropertyTypeMigratorBase.Delimiter" />) from Umbraco 7 to a JSON array.
+/// </summary>
+public sealed class DropDownMultiplePropertyTypeMigrator : PrevaluePropertyTypeMigratorBase
+{
+    private const string FromEditorAlias = "Umbraco.DropDownMultiple";
+
+    /// <inheritdoc />
+    protected override bool Multiple => true;
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="DropDownMultiplePropertyTypeMigrator" /> class.
+    /// </summary>
+    /// <param name="jsonSerializer">The JSON serializer.</param>
+    public DropDownMultiplePropertyTypeMigrator(IJsonSerializer jsonSerializer)
+        : base(FromEditorAlias, Constants.PropertyEditors.Aliases.DropDownListFlexible, jsonSerializer)
+    { }
+}

src/Umbraco.Deploy.Contrib/Migrators/Legacy/Content/DropDownPropertyTypeMigrator.cs

@@ -0,0 +1,23 @@
+using Umbraco.Cms.Core;
+using Umbraco.Cms.Core.Serialization;
+
+namespace Umbraco.Deploy.Contrib.Migrators.Legacy;
+
+/// <summary>
+/// Migrates the property value from the legacy <see cref="FromEditorAlias" /> editor containing prevalues (seperated by <see cref="PrevaluePropertyTypeMigratorBase.Delimiter" />) from Umbraco 7 to a JSON array.
+/// </summary>
+public sealed class DropDownPropertyTypeMigrator : PrevaluePropertyTypeMigratorBase
+{
+    private const string FromEditorAlias = "Umbraco.DropDown";
+
+    /// <inheritdoc />
+    protected override bool Multiple => true;
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="DropDownPropertyTypeMigrator" /> class.
+    /// </summary>
+    /// <param name="jsonSerializer">The JSON serializer.</param>
+    public DropDownPropertyTypeMigrator(IJsonSerializer jsonSerializer)
+        : base(FromEditorAlias, Constants.PropertyEditors.Aliases.DropDownListFlexible, jsonSerializer)
+    { }
+}

src/Umbraco.Deploy.Contrib/Migrators/Legacy/Content/DropdownlistMultiplePublishKeysPropertyTypeMigrator.cs

@@ -0,0 +1,23 @@
+using Umbraco.Cms.Core;
+using Umbraco.Cms.Core.Serialization;
+
+namespace Umbraco.Deploy.Contrib.Migrators.Legacy;
+
+/// <summary>
+/// Migrates the property value from the legacy <see cref="FromEditorAlias" /> editor containing prevalues (seperated by <see cref="PrevaluePropertyTypeMigratorBase.Delimiter" />) from Umbraco 7 to a JSON array.
+/// </summary>
+public sealed class DropdownlistMultiplePublishKeysPropertyTypeMigrator : PrevaluePropertyTypeMigratorBase
+{
+    private const string FromEditorAlias = "Umbraco.DropdownlistMultiplePublishKeys";
+
+    /// <inheritdoc />
+    protected override bool Multiple => true;
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="DropdownlistMultiplePublishKeysPropertyTypeMigrator" /> class.
+    /// </summary>
+    /// <param name="jsonSerializer">The JSON serializer.</param>
+    public DropdownlistMultiplePublishKeysPropertyTypeMigrator(IJsonSerializer jsonSerializer)
+        : base(FromEditorAlias, Constants.PropertyEditors.Aliases.DropDownListFlexible, jsonSerializer)
+    { }
+}

src/Umbraco.Deploy.Contrib/Migrators/Legacy/Content/DropdownlistPublishingKeysPropertyTypeMigrator.cs

@@ -0,0 +1,23 @@
+using Umbraco.Cms.Core;
+using Umbraco.Cms.Core.Serialization;
+
+namespace Umbraco.Deploy.Contrib.Migrators.Legacy;
+
+/// <summary>
+/// Migrates the property value from the legacy <see cref="FromEditorAlias" /> editor containing prevalues (seperated by <see cref="PrevaluePropertyTypeMigratorBase.Delimiter" />) from Umbraco 7 to a JSON array.
+/// </summary>
+public sealed class DropdownlistPublishingKeysPropertyTypeMigrator : PrevaluePropertyTypeMigratorBase
+{
+    private const string FromEditorAlias = "Umbraco.DropdownlistPublishingKeys";
+
+    /// <inheritdoc />
+    protected override bool Multiple => true;
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="DropdownlistPublishingKeysPropertyTypeMigrator" /> class.
+    /// </summary>
+    /// <param name="jsonSerializer">The JSON serializer.</param>
+    public DropdownlistPublishingKeysPropertyTypeMigrator(IJsonSerializer jsonSerializer)
+        : base(FromEditorAlias, Constants.PropertyEditors.Aliases.DropDownListFlexible, jsonSerializer)
+    { }
+}

src/Umbraco.Deploy.Contrib/Migrators/Legacy/Content/PrevaluePropertyTypeMigratorBase.cs

@@ -28,10 +28,20 @@ public abstract class PrevaluePropertyTypeMigratorBase : PropertyTypeMigratorBas
     /// <summary>
     /// Initializes a new instance of the <see cref="PrevaluePropertyTypeMigratorBase" /> class.
     /// </summary>
-    /// <param name="editorAlias">The editor alias.</param>
+    /// <param name="editorAlias">The editor alias (without the prefix added by <see cref="PrevalueArtifactMigrator" />).</param>
     /// <param name="jsonSerializer">The JSON serializer.</param>
     protected PrevaluePropertyTypeMigratorBase(string editorAlias, IJsonSerializer jsonSerializer)
-        : base(EditorAliasPrefix + editorAlias, editorAlias)
+        : this(EditorAliasPrefix + editorAlias, editorAlias, jsonSerializer)
+    { }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="PrevaluePropertyTypeMigratorBase" /> class.
+    /// </summary>
+    /// <param name="fromEditorAlias">The editor alias to migrate from.</param>
+    /// <param name="toEditorAlias">The editor alias to migrate to.</param>
+    /// <param name="jsonSerializer">The JSON serializer.</param>
+    protected PrevaluePropertyTypeMigratorBase(string fromEditorAlias, string toEditorAlias, IJsonSerializer jsonSerializer)
+        : base(fromEditorAlias, toEditorAlias)
         => _jsonSerializer = jsonSerializer;
 
     /// <inheritdoc />