Only store GUID of migrated start node IDs

Author: ronaldbarendse

src/Umbraco.Deploy.Contrib/Migrators/Legacy/DataType/ContentPickerReplaceDataTypeArtifactMigratorBase.cs

@@ -26,11 +26,18 @@ protected ContentPickerReplaceDataTypeArtifactMigratorBase(string fromEditorAlia
     /// <inheritdoc />
     protected override IDictionary<string, object>? MigrateConfiguration(IDictionary<string, object> configuration)
     {
-        if (configuration.TryGetValue("startNodeId", out var startNodeIdValue) &&
-            (startNodeIdValue?.ToString() is not string startNodeIdString || !UdiParser.TryParse(startNodeIdString, out _)))
+        if (configuration.TryGetValue("startNodeId", out var startNodeIdValue))
         {
-            // Remove invalid start node id
-            configuration.Remove("startNodeId");
+            if (startNodeIdValue?.ToString() is not string startNodeId || !UdiParser.TryParse(startNodeId, out GuidUdi? udi))
+            {
+                // Remove invalid start node ID
+                configuration.Remove("startNodeId");
+            }
+            else
+            {
+                // Update start node ID to GUID
+                configuration["startNodeId"] = udi.Guid;
+            }
         }
 
         return configuration;

src/Umbraco.Deploy.Contrib/Migrators/Legacy/DataType/MediaPickerDataTypeArtifactMigrator.cs

@@ -27,11 +27,18 @@ public MediaPickerDataTypeArtifactMigrator(PropertyEditorCollection propertyEdit
     /// <inheritdoc />
     protected override IDictionary<string, object>? MigrateConfiguration(IDictionary<string, object> fromConfiguration)
     {
-        if (fromConfiguration.TryGetValue("startNodeId", out var startNodeIdValue) &&
-            (startNodeIdValue?.ToString() is not string startNodeId || !UdiParser.TryParse(startNodeId, out _)))
+        if (fromConfiguration.TryGetValue("startNodeId", out var startNodeIdValue))
         {
-            // Remove invalid start node ID
-            fromConfiguration.Remove("startNodeId");
+            if (startNodeIdValue?.ToString() is not string startNodeId || !UdiParser.TryParse(startNodeId, out GuidUdi? udi))
+            {
+                // Remove invalid start node ID
+                fromConfiguration.Remove("startNodeId");
+            }
+            else
+            {
+                // Update start node ID to GUID
+                fromConfiguration["startNodeId"] = udi.Guid;
+            }
         }
 
         return fromConfiguration;

src/Umbraco.Deploy.Contrib/Migrators/Legacy/DataType/MediaPickerReplaceDataTypeArtifactMigratorBase.cs

@@ -39,11 +39,18 @@ protected MediaPickerReplaceDataTypeArtifactMigratorBase(string fromEditorAlias,
             configuration["multiPicker"] = Multiple;
         }
 
-        if (configuration.TryGetValue("startNodeId", out var startNodeIdValue) &&
-            (startNodeIdValue?.ToString() is not string startNodeId || !UdiParser.TryParse(startNodeId, out _)))
+        if (configuration.TryGetValue("startNodeId", out var startNodeIdValue))
         {
-            // Remove invalid start node ID
-            configuration.Remove("startNodeId");
+            if (startNodeIdValue?.ToString() is not string startNodeId || !UdiParser.TryParse(startNodeId, out GuidUdi? udi))
+            {
+                // Remove invalid start node ID
+                configuration.Remove("startNodeId");
+            }
+            else
+            {
+                // Update start node ID to GUID
+                configuration["startNodeId"] = udi.Guid;
+            }
         }
 
         return configuration;