PR updates

Author: acoumb

src/Umbraco.Forms.Integrations.Crm.ActiveCampaign/ActiveCampaignContactsWorkflow.cs

@@ -69,9 +69,9 @@ public override WorkflowExecutionStatus Execute(WorkflowExecutionContext context
 
                 if(contacts.Contacts.Count > 0 && !_settings.AllowContactUpdate)
                 {
-                    _logger.LogError("ActiveCampaign contact update is not allowed.");
+                    _logger.LogInformation("Contact already exists in ActiveCampaign and workflow is configured to not apply updates, so update of information was skipped.");
 
-                    return WorkflowExecutionStatus.Cancelled;
+                    return WorkflowExecutionStatus.Completed;
                 }
 
                 var requestDto = new ContactDetailDto { Contact = Build(context.Record) };

src/Umbraco.Forms.Integrations.Crm.ActiveCampaign/Configuration/ActiveCampaignSettings.cs

@@ -8,11 +8,11 @@ public ActiveCampaignSettings()
             ContactFields = new List<ContactFieldSettings>();
         }
 
-        public string BaseUrl { get; set; }
+        public string BaseUrl { get; }
 
-        public string ApiKey { get; set; }
+        public string ApiKey { get; }
 
-        public bool AllowContactUpdate { get; set; }
+        public bool AllowContactUpdate { get; }
 
         public List<ContactFieldSettings> ContactFields { get; set; }
     }

src/Umbraco.Forms.Integrations.Crm.Hubspot/Configuration/HubspotSettings.cs

@@ -3,8 +3,8 @@ namespace Umbraco.Forms.Integrations.Crm.Hubspot.Configuration
 {
     public class HubspotSettings
     {
-        public string ApiKey { get; set; }
+        public string ApiKey { get; }
 
-        public bool AllowContactUpdate { get; set; }
+        public bool AllowContactUpdate { get; }
     }
 }

src/Umbraco.Forms.Integrations.Crm.Hubspot/Services/HubspotContactService.cs

@@ -203,10 +203,10 @@ public async Task<CommandResult> PostContactAsync(Record record, List<MappedProp
                 if (response.StatusCode == HttpStatusCode.Conflict)
                 {
                     if (!_settings.AllowContactUpdate)
-                        _logger.LogError("Hubspot contact update is not allowed.");
+                        _logger.LogInformation("Contact already exists in HubSpot CRM and workflow is configured to not apply updates, so update of information was skipped.");
                     return _settings.AllowContactUpdate
                         ? await UpdateContactAsync(record, authenticationDetails, propertiesRequestV1, emailValue)
-                        : CommandResult.Failed;
+                        : CommandResult.Success;
                 }
                 else
                 {