Skip to content

Commit 3ed1258

Browse files
committed
Use IFormStorage with V8
1 parent 145bda1 commit 3ed1258

File tree

2 files changed

+32
-16
lines changed

2 files changed

+32
-16
lines changed

src/Umbraco.Forms.Integrations.Automation.Zapier/Controllers/PollingController.cs

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
using System.Collections.Generic;
33

44
using System.Linq;
5-
using Umbraco.Forms.Core.Data.Storage;
5+
66
using Umbraco.Forms.Core.Providers.Models;
77
using Umbraco.Forms.Core.Services;
88
using Umbraco.Forms.Integrations.Automation.Zapier.Configuration;
@@ -12,12 +12,11 @@
1212
using Microsoft.Extensions.Options;
1313

1414
using Umbraco.Cms.Web.Common.Controllers;
15-
using Umbraco.Cms.Core.Services;
1615
#else
1716
using System.Configuration;
1817

18+
using Umbraco.Forms.Core.Data.Storage;
1919
using Umbraco.Web.WebApi;
20-
using Umbraco.Core.Services;
2120
#endif
2221

2322
namespace Umbraco.Forms.Integrations.Automation.Zapier.Controllers
@@ -26,20 +25,21 @@ public class PollingController : UmbracoApiController
2625
{
2726
private readonly ZapierSettings Options;
2827

29-
private readonly IFormService _formService;
30-
3128
private readonly IUserValidationService _userValidationService;
3229

3330
#if NETCOREAPP
31+
private readonly IFormService _formService;
32+
3433
private readonly IWorkflowService _workflowService;
3534

36-
public PollingController(IOptions<ZapierSettings> options, IFormService formService, IWorkflowService workflowService,
37-
IRecordReaderService recordReaderService, IUserValidationService userValidationService)
35+
public PollingController(IOptions<ZapierSettings> options, IFormService formService, IWorkflowService workflowService, IUserValidationService userValidationService)
3836
#else
3937
private readonly IWorkflowServices _workflowServices;
4038

41-
public PollingController(IFormService formService, IWorkflowServices workflowServices,
42-
IRecordReaderService recordReaderService, IUserValidationService userValidationService)
39+
private readonly IFormStorage _formStorage;
40+
41+
public PollingController(IWorkflowServices workflowServices,
42+
IFormStorage formStorage, IUserValidationService userValidationService)
4343
#endif
4444
{
4545
#if NETCOREAPP
@@ -50,9 +50,9 @@ public PollingController(IFormService formService, IWorkflowServices workflowSer
5050
Options = new ZapierSettings(ConfigurationManager.AppSettings);
5151

5252
_workflowServices = workflowServices;
53-
#endif
5453

55-
_formService = formService;
54+
_formStorage = formStorage;
55+
#endif
5656

5757
_userValidationService = userValidationService;
5858
}
@@ -86,7 +86,11 @@ public List<Dictionary<string, string>> GetFormsData()
8686
if (!isAuthorized) return null;
8787

8888
// 1. get forms
89+
#if NETCOREAPP
8990
var forms = _formService.Get();
91+
#else
92+
var forms = _formStorage.GetAll();
93+
#endif
9094
foreach (var form in forms)
9195
{
9296
#if NETCOREAPP

src/Umbraco.Forms.Integrations.Automation.Zapier/Controllers/SubscriptionController.cs

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System;
22
using System.Linq;
3+
34
using Umbraco.Forms.Core.Services;
45
using Umbraco.Forms.Integrations.Automation.Zapier.Configuration;
56
using Umbraco.Forms.Integrations.Automation.Zapier.Models.Dtos;
@@ -13,6 +14,7 @@
1314
#else
1415
using System.Web.Http;
1516
using System.Configuration;
17+
using Umbraco.Forms.Core.Data.Storage;
1618
using Umbraco.Web.WebApi;
1719
#endif
1820

@@ -26,18 +28,21 @@ public class SubscriptionController : UmbracoApiController
2628
private readonly ILogger<SubscriptionController> _logger;
2729

2830
private readonly IWorkflowService _workflowService;
31+
32+
private readonly IFormService _formService;
2933
#else
3034
private readonly IWorkflowServices _workflowServices;
31-
#endif
3235

33-
private readonly IFormService _formService;
36+
private readonly IFormStorage _formStorage;
37+
#endif
3438

3539
private readonly IUserValidationService _userValidationService;
3640

3741
#if NETCOREAPP
38-
public SubscriptionController(IOptions<ZapierSettings> options, ILogger<SubscriptionController> logger, IFormService formService, IWorkflowService workflowService, IUserValidationService userValidationService)
42+
public SubscriptionController(IOptions<ZapierSettings> options, ILogger<SubscriptionController> logger, IFormService formService,
43+
IWorkflowService workflowService, IUserValidationService userValidationService)
3944
#else
40-
public SubscriptionController(IFormService formService, IWorkflowServices workflowServices, IUserValidationService userValidationService)
45+
public SubscriptionController(IWorkflowServices workflowServices, IFormStorage formStorage, IUserValidationService userValidationService)
4146
#endif
4247
{
4348
#if NETCOREAPP
@@ -46,12 +51,15 @@ public SubscriptionController(IFormService formService, IWorkflowServices workfl
4651
_logger = logger;
4752

4853
_workflowService = workflowService;
54+
55+
_formService = formService;
4956
#else
5057
Options = new ZapierSettings(ConfigurationManager.AppSettings);
5158

5259
_workflowServices = workflowServices;
60+
61+
_formStorage = formStorage;
5362
#endif
54-
_formService = formService;
5563

5664
_userValidationService = userValidationService;
5765
}
@@ -88,7 +96,11 @@ public bool UpdatePreferences([FromBody] SubscriptionDto dto)
8896
try
8997
{
9098
// 1. get forms
99+
#if NETCOREAPP
91100
var forms = _formService.Get();
101+
#else
102+
var forms = _formStorage.GetAll();
103+
#endif
92104
foreach (var form in forms)
93105
{
94106
// 2. check if 'Trigger Zapier' workflow exists on the form

0 commit comments

Comments
 (0)