V14: Integrations (HubSpot/Forms)

- Change Forms to Contact
- Remove AppPlugins
- Remove Umbraco.Cms.Integrations.OAuthProxy references and controllers
- Remove V10&V12 test sites
- Some changes to current controllers

Author: dtng95

src/Umbraco.Forms.Integrations.Crm.Hubspot/Api/Management/Controllers/Forms/AuthorizeController.cs

@@ -10,14 +10,14 @@
 
 namespace Umbraco.Forms.Integrations.Crm.Hubspot.Api.Management.Controllers.Forms
 {
-    public class AuthorizeController : FormsControllerBase
+    public class AuthorizeController : ContactControllerBase
     {
         public AuthorizeController(IContactService contactService) : base(contactService)
         {
         }
 
         [HttpPost("authorize")]
         [ProducesResponseType(typeof(Task<AuthorizationResult>), StatusCodes.Status200OK)]
-        public IActionResult Authorize([FromBody] AuthorizationRequest request) => Ok(ContactService.AuthorizeAsync(request.Code));
+        public async Task<IActionResult> Authorize([FromBody] AuthorizationRequest request) => Ok(await ContactService.AuthorizeAsync(request.Code));
     }
 }

src/Umbraco.Forms.Integrations.Crm.Hubspot/Api/Management/Controllers/Forms/FormsControllerBase.cs renamed to src/Umbraco.Forms.Integrations.Crm.Hubspot/Api/Management/Controllers/Forms/ContactControllerBase.cs

@@ -11,12 +11,12 @@
 namespace Umbraco.Forms.Integrations.Crm.Hubspot.Api.Management.Controllers.Forms
 {
     [ApiVersion("1.0")]
-    [BackOfficeRoute($"{Constants.ManagementApi.RootPath}/v{{version:apiVersion}}/forms")]
-    [ApiExplorerSettings(GroupName = Constants.ManagementApi.FormsGroupName)]
-    public class FormsControllerBase : HubspotControllerBase
+    [BackOfficeRoute($"{Constants.ManagementApi.RootPath}/v{{version:apiVersion}}/contacts")]
+    [ApiExplorerSettings(GroupName = Constants.ManagementApi.ContactGroupName)]
+    public class ContactControllerBase : HubspotControllerBase
     {
         protected readonly IContactService ContactService;
-        public FormsControllerBase(IContactService contactService)
+        public ContactControllerBase(IContactService contactService)
         {
             ContactService = contactService;
         }

src/Umbraco.Forms.Integrations.Crm.Hubspot/Api/Management/Controllers/Forms/DeauthorizeController.cs

@@ -10,7 +10,7 @@
 
 namespace Umbraco.Forms.Integrations.Crm.Hubspot.Api.Management.Controllers.Forms
 {
-    public class DeauthorizeController : FormsControllerBase
+    public class DeauthorizeController : ContactControllerBase
     {
         public DeauthorizeController(IContactService contactService) : base(contactService)
         {

src/Umbraco.Forms.Integrations.Crm.Hubspot/Api/Management/Controllers/Forms/GetAllPropertiesController.cs

@@ -11,14 +11,14 @@
 
 namespace Umbraco.Forms.Integrations.Crm.Hubspot.Api.Management.Controllers.Forms
 {
-    public class GetAllPropertiesController : FormsControllerBase
+    public class GetAllPropertiesController : ContactControllerBase
     {
         public GetAllPropertiesController(IContactService contactService) : base(contactService)
         {
         }
 
         [HttpGet("properties")]
         [ProducesResponseType(typeof(IEnumerable<Property>), StatusCodes.Status200OK)]
-        public IActionResult GetAll() => Ok(ContactService.GetContactPropertiesAsync());
+        public async Task<IActionResult> GetAll() => Ok(await ContactService.GetContactPropertiesAsync());
     }
 }

src/Umbraco.Forms.Integrations.Crm.Hubspot/Api/Management/Controllers/Forms/GetAuthenticationUrlController.cs

@@ -9,13 +9,13 @@
 
 namespace Umbraco.Forms.Integrations.Crm.Hubspot.Api.Management.Controllers.Forms
 {
-    public class GetAuthenticationUrlController : FormsControllerBase
+    public class GetAuthenticationUrlController : ContactControllerBase
     {
         public GetAuthenticationUrlController(IContactService contactService) : base(contactService)
         {
         }
 
-        [HttpGet("auth-url")]
+        [HttpGet("auth/url")]
         [ProducesResponseType(typeof(string), StatusCodes.Status200OK)]
         public string GetAuthenticationUrl() => ContactService.GetAuthenticationUrl();
     }

src/Umbraco.Forms.Integrations.Crm.Hubspot/Api/Management/Controllers/Forms/IsAuthorizationConfiguredController.cs

@@ -9,13 +9,13 @@
 
 namespace Umbraco.Forms.Integrations.Crm.Hubspot.Api.Management.Controllers.Forms
 {
-    public class IsAuthorizationConfiguredController : FormsControllerBase
+    public class IsAuthorizationConfiguredController : ContactControllerBase
     {
         public IsAuthorizationConfiguredController(IContactService contactService) : base(contactService)
         {
         }
 
-        [HttpGet("auth-configured")]
+        [HttpGet("auth/configured")]
         [ProducesResponseType(typeof(string), StatusCodes.Status200OK)]
         public IActionResult IsAuthorizationConfigured() => Ok(ContactService.IsAuthorizationConfigured().ToString());
     }