V14: Integrations (ActiveCampaign/Forms)

- Minor updates on ActiveCampaignWorkflow
- Re generate api

Author: dtng95

src/Umbraco.Forms.Integrations.Crm.ActiveCampaign/ActiveCampaignContactsWorkflow.cs

@@ -63,13 +63,13 @@ public override async Task<WorkflowExecutionStatus> ExecuteAsync(WorkflowExecuti
                     .ValuesAsString();
 
                 // Check if contact exists.
-                var contacts = await _contactService.Get(email).ConfigureAwait(false);
+                var contacts = await _contactService.Get(email);
 
                 if(contacts.Contacts.Count > 0 && !_settings.AllowContactUpdate)
                 {
                     _logger.LogInformation("Contact already exists in ActiveCampaign and workflow is configured to not apply updates, so update of information was skipped.");
 
-                    return await Task.FromResult<WorkflowExecutionStatus>(WorkflowExecutionStatus.Completed);
+                    return WorkflowExecutionStatus.Completed;
                 }
 
                 var requestDto = new ContactDetailDto { Contact = Build(context.Record) };
@@ -88,7 +88,7 @@ public override async Task<WorkflowExecutionStatus> ExecuteAsync(WorkflowExecuti
                     }).ToList();
                 }
 
-                var contactId = await _contactService.CreateOrUpdate(requestDto, contacts.Contacts.Count > 0).ConfigureAwait(false);
+                var contactId = await _contactService.CreateOrUpdate(requestDto, contacts.Contacts.Count > 0);
 
                 if (string.IsNullOrEmpty(contactId))
                 {
@@ -100,11 +100,10 @@ public override async Task<WorkflowExecutionStatus> ExecuteAsync(WorkflowExecuti
                 // Associate contact with account if last one is specified.
                 if (!string.IsNullOrEmpty(Account))
                 {
-                    var associationResponse = _accountService.CreateAssociation(int.Parse(Account), int.Parse(contactId))
-                        .ConfigureAwait(false).GetAwaiter().GetResult();
+                    var associationResponse = _accountService.CreateAssociation(int.Parse(Account), int.Parse(contactId));
                 }
 
-                return WorkflowExecutionStatus.Failed;
+                return WorkflowExecutionStatus.Completed;
             }
             catch(Exception ex)
             {

src/Umbraco.Forms.Integrations.Crm.ActiveCampaign/Api/Management/Controllers/Contacts/GetCustomFieldsController.cs

@@ -19,6 +19,6 @@ public GetCustomFieldsController(IOptions<ActiveCampaignSettings> options, ICont
         [HttpGet("custom")]
         [ProducesResponseType(typeof(CustomFieldCollectionResponseDto), StatusCodes.Status200OK)]
         public async Task<IActionResult> GetCustomFields() =>
-            Ok(await _contactService.GetCustomFields().ConfigureAwait(false));
+            Ok(await _contactService.GetCustomFields());
     }
 }