Feedback updates

Author: acoumb

src/Umbraco.Forms.Integrations.Commerce.EMerchantPay/App_Plugins/UmbracoForms.Integrations/Commerce/eMerchantPay/customer-details-mapper.controller.js

@@ -32,7 +32,7 @@
 
     function init() {
 
-        umbracoFormsIntegrationsCommerceEMerchantPayResource.getDefaultMappingFields().then(function (response) {
+        umbracoFormsIntegrationsCommerceEMerchantPayResource.getAvailableMappingFields().then(function (response) {
             vm.customerProperties = response;
         });
 

src/Umbraco.Forms.Integrations.Commerce.EMerchantPay/App_Plugins/UmbracoForms.Integrations/Commerce/eMerchantPay/emerchantpay.resource.js

@@ -8,9 +8,9 @@
                 $http.get(`${apiEndpoint}/GetCurrencies`),
                 "Failed to get resource");
         },
-        getDefaultMappingFields: function () {
+        getAvailableMappingFields: function () {
             return umbRequestHelper.resourcePromise(
-                $http.get(`${apiEndpoint}/GetDefaultMappingFields`),
+                $http.get(`${apiEndpoint}/GetAvailableMappingFields`),
                 "Failed to get resource");
         },
         getRequiredMappingFields: function () {

src/Umbraco.Forms.Integrations.Commerce.EMerchantPay/Constants.cs

@@ -60,5 +60,10 @@ public static class NotificationProperty
 
             public const string Status = "wpf_status";
         }
+
+        public static class PaymentStatus
+        {
+            public const string Approved = "approved";
+        }
     }
 }

src/Umbraco.Forms.Integrations.Commerce.EMerchantPay/Controllers/EmerchantPayController.cs

@@ -42,7 +42,7 @@ public EmerchantPayController(CurrencyHelper currencyHelper, MappingFieldHelper
         public IEnumerable<CurrencyDto> GetCurrencies() => _currencyHelper.GetCurrencies();
 
         [HttpGet]
-        public IEnumerable<string> GetDefaultMappingFields() => new[]
+        public IEnumerable<string> GetAvailableMappingFields() => new[]
         {
             "Email",
             "FirstName",

src/Umbraco.Forms.Integrations.Commerce.EMerchantPay/Controllers/PaymentProviderController.cs

@@ -79,7 +79,7 @@ public HttpResponseMessage NotifyPayment(string formId, string recordUniqueId, s
                 var paymentStatusField = record.GetRecordField(Guid.Parse(statusFieldId));
                 paymentStatusField.Values.Add(reconcileResponse.Status);
 
-                if(approve)
+                if(approve && notificationDto.Status == Constants.PaymentStatus.Approved)
                 {
                     _recordService.Approve(record, form);
                 }