Skip to content

Default Workflows - documentation out of date and seemingly settings is now Dictionary<string, string> which doesn't seem right #1440

@cheeseytoastie

Description

@cheeseytoastie

Which Umbraco Forms version are you using? (Please write the exact version, example: 13.4.0)

16.1.0

Which Umbraco version are you using? (Please write the exact version, example: 13.5.2)

16.1.1

Issue summary

Taking the default workflows code from https://docs.umbraco.com/umbraco-forms/developer/extending/customize-default-workflows

It doesn't seem to work. I tried an upgrade from v13 and this is one of the things I've hit.

Specifics

It looks like the following changes are required (but I can't get past the last step to build and validate it works which usually means I've screwed something up at the start);

  1. Core.Attributes.Setting this has become (??) Umbraco.Forms.Core.Attributes.SettingAttribute (add an include and shorten I guess?)
  2. The line
    View = _hostingEnvironment.ToAbsolute(settingItem.GetSettingView()),
    perhaps becomes:
    View = _hostingEnvironment.ToAbsolute(settingItem.View),
  3. However even after the changes above I can't work out what to do with:
    defaultWorkflow.Settings = workflowSettings;
    This looks like it's now expecting a Dictionary<string, string> which doesn't make any sense to me as it used to be List

I'm probably misunderstanding a change here but either way the documentation needs updating to the current method.

Steps to reproduce

Install Umbraco forms into v16.
Create a default workflow as per the documentation https://docs.umbraco.com/umbraco-forms/developer/extending/customize-default-workflows

Expected result / actual result

Documentation should reflect the recent changes and you should have a default workflow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions