Redirect Workflow Fails from any page with non-ASCII characters in the URL.

[markadrake]

Which Umbraco Forms version are you using? (Please write the exact version, example: 13.4.0)

13.7.0

Which Umbraco version are you using? (Please write the exact version, example: 13.5.2)

13.10.1

Issue summary

We have Chinese enabled on a multilingual site, and the URLs support UTF-8, so they have Chinese characters.

Any Umbraco Form submission with a redirect workflow that redirects to such a page will result in an error. Kestrel does not support non-ASCII characters (the HTTP standard does not either). When these characters are typed into the browser, AFAIK, the browser is doing us a solid and converting them to ASCII.

If HQ agrees this is an issue, I would like to propose that Umbraco update Umbraco Forms to ensure the URL is encoded as a safety measure.

(This is all from the default setup of Umbraco. I have not customized how Umbraco constructs these paths. So I'm recommending that Umbraco build in the safety measure to handle this OOTB.)

Since the code is not visible to me, would anyone happen to know whether UF is extensible so I can patch its behavior myself? (e.g., update the workflow logic/handling for redirects)

Specifics

No response

Steps to reproduce

• Enable Chinese in your Umbraco site
• Create a Chinese "thank you" page with Chinese characters in the content node name
• Create an Umbraco Form and set it to redirect to your Chinese "thank you" page
• Place the form anywhere on your Umbraco site
• Fill out the form

Expected result / actual result

By default, Umbraco URLs for content nodes use UTF-8 characters.

But Kestrel throws an error when this same URL, not encoded, is passed into an HTTP header:

[markadrake]

What I meant to say is that if the URL contains non-ASCII characters, it should be percent-encoded in this HTTP redirect header.

[rickbutterfield]

Hi @markadrake! Thanks for raising this. I think you're right in saying that this should be handled by the CMS rather than something specific in Forms (we are using the underlying RedirectToUmbracoPage methods in Forms when redirecting on submit).

There is an alternative option for you in that you can set a URL in the HttpContext with a key of FormsRedirectAfterFormSubmitUrl (or strongly typed constant of Umbraco.Forms.Core.Constants.ItemKeys.RedirectAfterFormSubmitUrl)

For example in a custom workflow...

public override async Task<WorkflowExecutionStatus> ExecuteAsync(WorkflowExecutionContext context)
{
    HttpContext httpContext = _httpContextAccessor.GetRequiredHttpContext();

    string url = "/这是一个感谢页面";
    string parsedUrl = HttpUtility.UrlEncode(url);
    httpContext.Items.Add(Constants.ItemKeys.RedirectAfterFormSubmitUrl, parsedUrl );

    return WorkflowExecutionStatus.Completed;
}