Align returned values with PhysicalFileSystem when blob does not exist

Author: ronaldbarendse

src/Umbraco.StorageProviders.AzureBlob/IO/AzureBlobFileSystem.cs

@@ -1,3 +1,4 @@
+using System.Net;
 using Azure;
 using Azure.Storage.Blobs;
 using Azure.Storage.Blobs.Models;
@@ -12,6 +13,10 @@ namespace Umbraco.StorageProviders.AzureBlob.IO;
 /// <inheritdoc />
 public sealed class AzureBlobFileSystem : IAzureBlobFileSystem, IFileProviderFactory
 {
+    // When not found, default to 1-1-1601 00:00:00 +00:00 for created/last modified and -1 for size to align with PhysicalFileSystem
+    private static readonly DateTimeOffset _notFoundDateTimeOffset = DateTimeOffset.FromUnixTimeSeconds(-11644473600);
+    private const long NotFoundSize = -1;
+
     private readonly string _requestRootPath;
     private readonly string _containerRootPath;
     private readonly BlobContainerClient _container;
@@ -91,6 +96,9 @@ public IEnumerable<string> GetDirectories(string path)
 
     /// <inheritdoc />
     /// <exception cref="System.ArgumentNullException"><paramref name="path" /> is <c>null</c>.</exception>
+    /// <remarks>
+    /// Azure Blob Storage can only delete blobs, so deleting directories is always recursive.
+    /// </remarks>
     public void DeleteDirectory(string path)
     {
         ArgumentNullException.ThrowIfNull(path);
@@ -100,6 +108,9 @@ public void DeleteDirectory(string path)
 
     /// <inheritdoc />
     /// <exception cref="System.ArgumentNullException"><paramref name="path" /> is <c>null</c>.</exception>
+    /// <remarks>
+    /// Azure Blob Storage can only delete blobs, so deleting directories is always recursive.
+    /// </remarks>
     public void DeleteDirectory(string path, bool recursive)
     {
         ArgumentNullException.ThrowIfNull(path);
@@ -303,7 +314,14 @@ public DateTimeOffset GetLastModified(string path)
     {
         ArgumentNullException.ThrowIfNull(path);
 
-        return GetBlobClient(path).GetProperties().Value.LastModified;
+        try
+        {
+            return GetBlobClient(path).GetProperties().Value.LastModified;
+        }
+        catch (RequestFailedException ex) when (ex.Status == (int)HttpStatusCode.NotFound)
+        {
+            return _notFoundDateTimeOffset;
+        }
     }
 
     /// <inheritdoc />
@@ -312,7 +330,14 @@ public DateTimeOffset GetCreated(string path)
     {
         ArgumentNullException.ThrowIfNull(path);
 
-        return GetBlobClient(path).GetProperties().Value.CreatedOn;
+        try
+        {
+            return GetBlobClient(path).GetProperties().Value.CreatedOn;
+        }
+        catch (RequestFailedException ex) when (ex.Status == (int)HttpStatusCode.NotFound)
+        {
+            return _notFoundDateTimeOffset;
+        }
     }
 
     /// <inheritdoc />
@@ -321,7 +346,14 @@ public long GetSize(string path)
     {
         ArgumentNullException.ThrowIfNull(path);
 
-        return GetBlobClient(path).GetProperties().Value.ContentLength;
+        try
+        {
+            return GetBlobClient(path).GetProperties().Value.ContentLength;
+        }
+        catch (RequestFailedException ex) when (ex.Status == (int)HttpStatusCode.NotFound)
+        {
+            return NotFoundSize;
+        }
     }
 
     /// <inheritdoc />