Skip to content

Commit 0191a4c

Browse files
committed
ensure there is a origin for the :has selector
1 parent 0a626ae commit 0191a4c

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

packages/uui-menu-item/lib/uui-menu-item.element.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,9 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
297297
var(--uui-color-current)
298298
);
299299
}
300-
:host([active]) :has(#label-button:hover) #label-button-background,
300+
:host([active])
301+
#menu-item:has(#label-button:hover)
302+
#label-button-background,
301303
:host([active]) #caret-button:hover {
302304
background-color: var(
303305
--uui-menu-item-background-color-active-hover,
@@ -332,7 +334,7 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
332334
}
333335
/** Selected, not highlight mode */
334336
:host([selected]:not([select-mode='highlight'], [disabled]))
335-
:has(#label-button:hover)
337+
#menu-item:has(#label-button:hover)
336338
#label-button-background,
337339
:host([selected]:not([select-mode='highlight'], [disabled]))
338340
#caret-button:hover {
@@ -344,8 +346,7 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
344346
345347
/** highlight mode, default */
346348
:host([select-mode='highlight']:not([disabled], [active], [selectable]))
347-
#menu-item
348-
:has(#label-button:hover)
349+
#menu-item:has(#label-button:hover)
349350
#label-button-background {
350351
border-radius: var(--uui-border-radius);
351352
background-color: var(
@@ -363,8 +364,7 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
363364
364365
/** highlight mode, active & selected */
365366
:host([select-mode='highlight'][active][selected]:not([disabled]))
366-
#menu-item
367-
:has(#label-button:hover)
367+
#menu-item:has(#label-button:hover)
368368
#label-button-background {
369369
border-radius: var(--uui-border-radius);
370370
background-color: var(
@@ -443,14 +443,12 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
443443
}
444444
445445
:host([select-mode='highlight'][selectable]:not([disabled]))
446-
#menu-item
447-
:has(#label-button:hover)
446+
#menu-item:has(#label-button:hover)
448447
#label-button-background::after {
449448
opacity: 0.33;
450449
}
451450
:host([select-mode='highlight'][selected]:not([disabled]))
452-
#menu-item
453-
:has(#label-button:hover)
451+
#menu-item:has(#label-button:hover)
454452
#label-button-background::after {
455453
opacity: 0.66;
456454
}

0 commit comments

Comments
 (0)