Skip to content

Commit 1146940

Browse files
committed
build: changes all workflows to a main/production setup
1 parent dc445f3 commit 1146940

File tree

9 files changed

+17
-39
lines changed

9 files changed

+17
-39
lines changed

.github/workflows/azure-static-web-apps-delightful-beach-055ecb503.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,14 @@ on:
44
push:
55
branches:
66
- main
7-
- 'v*/main'
8-
- 'v*/dev'
9-
- 'v*/contrib'
7+
- production
108
- 'release/*'
119
# This is how azure builds staging environments
1210
pull_request:
1311
types: [opened, synchronize, reopened, closed]
1412
branches:
1513
- main
16-
- 'v*/main'
17-
- 'v*/dev'
18-
- 'v*/contrib'
14+
- production
1915
- 'release/*'
2016

2117
env:
@@ -44,7 +40,7 @@ jobs:
4440
app_build_command: 'npm run storybook:build'
4541
api_location: '' # Api source code path - optional
4642
output_location: '/storybook-static' # Built app content directory - optional
47-
production_branch: 'v1/main' # Production branch
43+
production_branch: 'production' # Production branch
4844
###### End of Repository/Build Configurations ######
4945

5046
close_pull_request_job:

.github/workflows/chromatic.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,8 @@ on:
1616
- 'packages/*/lib/**'
1717
- 'packages/*/assets/**'
1818
branches-ignore:
19-
- 'dependabot/**'
2019
- 'release/*'
21-
- 'Release/*'
22-
- 'main'
23-
- 'v*/main'
24-
- 'v*/release'
20+
- 'production'
2521

2622
# Allows you to run this workflow manually from the Actions tab
2723
workflow_dispatch:
@@ -66,6 +62,6 @@ jobs:
6662
exitOnceUploaded: true
6763
onlyChanged: true,
6864
untraced: '.storybook/images/**/*,storyhelpers/**/*'
69-
autoAcceptChanges: 'v*/contrib'
65+
autoAcceptChanges: 'main'
7066
externals: |
7167
.storybook/images/**

.github/workflows/codeql-analysis.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,11 @@ on:
44
push:
55
branches:
66
- main
7-
- dev
8-
- 'v*/dev'
9-
- 'v*/main'
10-
- 'v*/contrib'
117
- 'release/*'
128
pull_request:
139
# The branches below must be a subset of the branches above
1410
branches:
15-
- dev
16-
- 'v*/dev'
17-
- 'v*/contrib'
11+
- main
1812
- 'release/*'
1913
schedule:
2014
- cron: '39 20 * * 3'

.github/workflows/publish.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,10 @@ name: Publish
33
on:
44
push:
55
branches:
6-
- main
7-
- 'v*/main'
6+
- production
87

98
# Allows you to run this workflow manually from the Actions tab
109
workflow_dispatch:
11-
inputs:
12-
sha:
13-
description: The commit hash referring to the commit to check.
14-
required: false
15-
ref:
16-
description: The head branch associated with the pull request.
17-
required: false
1810

1911
env:
2012
NODE_OPTIONS: --max_old_space_size=16384

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
# Triggers the workflow on push or pull request events but only for the dev branch
66
pull_request:
77
branches-ignore:
8-
- 'v*/main'
8+
- production
99

1010
# Allows you to run this workflow manually from the Actions tab
1111
workflow_dispatch:

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,5 +144,5 @@ See the rest of [the scripts here](docs/SCRIPTS.md).
144144
- 📥 Pull requests and 🌟 Stars are always welcome.
145145
- Read our [contributing guide](docs/CONTRIBUTING.md) to get started.
146146
- Please report bugs and feature requests in the [issue tracker](https://github.com/umbraco/Umbraco.UI/issues)
147-
- The main branch is the latest development branch. Please make your pull requests against this branch: `v1/contrib`
148-
- You can see the latest features in the Storybook attached to this branch: [v1/contrib](https://delightful-beach-055ecb503-v1contrib.westeurope.azurestaticapps.net/)
147+
- The main branch is the latest development branch. Please make your pull requests against this branch: `main`
148+
- You can see the latest features in the Storybook attached to this branch: [main](https://delightful-beach-055ecb503-main.westeurope.azurestaticapps.net/)

docs/RELEASE_INSTRUCTION.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,23 @@
22

33
1. Create a new branch for the release. We need a good naming convention: `release/<Version>` (example: `release/1.12.0`).
44
1. Review new release PR (either [on GitHub](https://github.com/umbraco/Umbraco.UI/compare/)).
5-
1. Make a PR from the new branch to the `main` branch.
65
1. Run `npm run lerna:version` and Lerna will suggest a version bump for each package.
76
1. Review the new version numbers and accept with `y` and Lerna will now bump each package and update the local CHANGELOG.md file using descriptions from the conventional commits, Lerna will also reinstall NPM and generate a new lockfile.
87
1. We are continuously improving the way Lerna detects changes, so you may run into packages being bumped and you do not know why. It is okay to publish a package that has not been changed in order not to mess too much with the logic that Lerna uses to detect changes.
98
1. Push all the changes to your release branch.
10-
1. Make a PR from the new branch to the `main` branch.
9+
1. Make a PR from the new branch to the `production` branch.
1110
1. Add the `ignore-for-release`-label to the PR.
1211
1. Wait for GitHub checks to pass.
1312
1. Github will post a comment with a test link to try out that the release works in Storybook. Please check that it works.
14-
1. Merge PR into main **using the Merge strategy** (very important so the history is not mangled) - this will trigger two actions - `Publish`, and `Azure Static Web Apps CI/CD`. The `Publish` workflow is responsible for publishing packages to NPM. It will only publish the packages that have higher version that previously published ones. The azure workflow will build and publish UI library Storybook.
15-
1. Merge the `v1/main` branch with the `v1/contrib` branch by writing `git merge origin/main` and then push the changes.
13+
1. Merge PR into production **using the Merge strategy** (very important so the history is not mangled) - this will trigger two actions - `Publish`, and `Azure Static Web Apps CI/CD`. The `Publish` workflow is responsible for publishing packages to NPM. It will only publish the packages that have higher version that previously published ones. The azure workflow will build and publish UI library Storybook.
14+
1. Merge the `production` back into the `main` branch by writing `git merge origin/production` when on the `main` branch, and then push the changes. (This way we ensure that the `main` branch is always up to date with the latest release and accompanying release notes).
1615
1. Go to Github and [create a new release](https://github.com/umbraco/Umbraco.UI/releases/new).
1716
1. Using tags on the release, we want to target `vx.x.x` where "x.x.x" is the version number that the UUI package was bumped to during the release.
1817
1. Select the prevous version, in relation to your release, in `Previous tag` and press `Generate release notes`.
1918
1. Check the generated release notes, see if PRs are in the right category, if not append labels to them and return to generate again.
2019
1. The UI Library has now been updated.
21-
1. Write an post on the UI Library Slack Channel evt. update Backoffice.
20+
1. Write an post on the UI Library Slack Channel.
21+
1. Consider when to update the Backoffice.
2222

2323
## How to clear tags
2424

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@
152152
"*": "prettier --ignore-unknown --write"
153153
},
154154
"storybook": {
155-
"url": "https://v1-contrib--62189360eeb21b003ab2f4ad.chromatic.com/"
155+
"url": "https://uui.umbraco.com"
156156
},
157157
"packageManager": "[email protected]"
158158
}

packages/uui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,6 @@
130130
"access": "public"
131131
},
132132
"storybook": {
133-
"url": "https://v1-contrib--62189360eeb21b003ab2f4ad.chromatic.com/"
133+
"url": "https://uui.umbraco.com"
134134
}
135135
}

0 commit comments

Comments
 (0)