Merge pull request #115 from umbraco/Release/Patch-220128

Author: nielslyngsoe

.eslintrc.js

@@ -1,5 +1,5 @@
 module.exports = {
-  ignorePatterns: ['vite.*.js'],
+  ignorePatterns: ['vite.*.js', 'src/**/*'],
   root: true,
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint', 'html', 'import'],
@@ -16,6 +16,7 @@ module.exports = {
     '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-inferrable-types': 'off',
     '@typescript-eslint/ban-ts-comment': 'off', //TODO: Remove (maybe)
     '@typescript-eslint/ban-types': 'off', //TODO: Remove (maybe)
   },

.github/workflows/azure-static-web-apps-delightful-beach-055ecb503.yml

@@ -4,10 +4,16 @@ on:
   push:
     branches:
       - main
+  # This is how azure builds staging environments
+  pull_request:
+    types: [opened, synchronize, reopened, closed]
+    branches:
+      - main
 
 jobs:
   test:
     # The type of runner that the job will run on
+    if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')
     runs-on: ubuntu-latest
 
     strategy:
@@ -23,6 +29,7 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
       - run: npm ci
+      - run: npm run lint
       - run: npm run build:prod
 
   build_and_deploy_job:

.github/workflows/tests.yml

@@ -31,4 +31,5 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
       - run: npm install
+      - run: npm run lint
       - run: npm run build:prod

.gitignore

@@ -34,3 +34,7 @@ debug.log
 out-css
 *.log
 .eslintcache
+*.tgz
+
+# old source
+/src/**/*

.husky/common.sh

@@ -0,0 +1,8 @@
+command_exists () {
+  command -v "$1" >/dev/null 2>&1
+}
+
+# Workaround for Windows 10, Git Bash and Yarn
+if command_exists winpty && test -t 1; then
+  exec < /dev/tty
+fi

.husky/pre-commit

@@ -1,4 +1,5 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
+. "$(dirname "$0")/common.sh"
 
 npx lint-staged

docs/RELEASE_INSTRUCTION.md

@@ -0,0 +1,34 @@
+# UI Library Release workflow
+
+1. Create a new branch for the release. We need a good naming convention: `Release/<patch/minor/major>-<YYMMDD>` (example: `Release/Patch-220128`)
+1. Review new release PR (either [on GitHub](https://github.com/umbraco/Umbraco.UI/compare/) or through `npm run lerna:diff`)
+1. Make a PR from the new branch to the main branch
+1. Wait for GitHub checks to pass.
+1. Run `npm run lerna:version`
+1. Select new version number for every package in the terminal
+1. Confirm the new versions - **this step is irreversible**. It will create tags and commit those to the remote. [Check how to clear tags.](#How-to-clear-tags)
+1. Commit `package-lock.json` to your release branch
+1. Wait for GitHub checks to pass. There will be one check that fails and this is the one triggered by a commit made by `npm run lerna:version` command. This fails because it runs build with old `package-lock.json` that does not have updated versions of the packages. After you commit the new package-lock the check should pass.
+1. Merge PR into main - this will trigger two actions - `Publish`, and `Azure Static Web Apps CI/CD`. The `Publish` workflow is responsible for publishing packages to NPM. It will only publish the packages that have higher version that previously published ones. The azure workflow will build and publish UI library Storybook
+1. Merge main branch into dev branch
+
+## How to clear tags
+
+If something goes wrong during the publish workflow, you might end up with tag numbers not corresponding to the current versions of the packages. Tags are stored both on remote and on local repository.
+
+1. Go to Github and remove all tags with higher versions then the last published version.
+2. Then delete all your local tags and replace them with the tags from the remote. To do that run the following inside your local repository.
+
+OSX
+
+```zsh
+git tag -l | xargs git tag -d
+git fetch --tags
+```
+
+WINDOWS
+
+```powershell
+git tag -l | %{git tag -d $_}
+git fetch --tags
+```