optimize code

nielslyngsoe · nielslyngsoe · commit 2bb4b11ddf6b · 2024-11-26T21:15:18.000+01:00
diff --git a/packages/uui-table/lib/uui-table-row.element.ts b/packages/uui-table/lib/uui-table-row.element.ts
@@ -56,17 +56,13 @@ export class UUITableRowElement extends SelectOnlyMixin(
   private updateChildSelectOnly() {
     if (this.slotCellNodes) {
       this.slotCellNodes.forEach(el => {
-        if (this.elementIsTableCell(el)) {
+        if (el instanceof UUITableCellElement) {
           el.disableChildInteraction = this.selectOnly;
         }
       });
     }
   }
 
-  private elementIsTableCell(element: unknown): element is UUITableCellElement {
-    return element instanceof UUITableCellElement;
-  }
-
   render() {
     return html` <slot @slotchanged=${this.updateChildSelectOnly}></slot> `;
   }

Original file line number	Diff line number	Diff line change
`@@ -56,17 +56,13 @@ export class UUITableRowElement extends SelectOnlyMixin(`
`56`	`56`	`private updateChildSelectOnly() {`
`57`	`57`	`if (this.slotCellNodes) {`
`58`	`58`	`this.slotCellNodes.forEach(el => {`
`59`		`- if (this.elementIsTableCell(el)) {`
	`59`	`+ if (el instanceof UUITableCellElement) {`
`60`	`60`	`el.disableChildInteraction = this.selectOnly;`
`61`	`61`	`}`
`62`	`62`	`});`
`63`	`63`	`}`
`64`	`64`	`}`
`65`	`65`
`66`		`- private elementIsTableCell(element: unknown): element is UUITableCellElement {`
`67`		`- return element instanceof UUITableCellElement;`
`68`		`- }`
`69`		`-`
`70`	`66`	`render() {`
`71`	`67`	return html` <slot @slotchanged=${this.updateChildSelectOnly}></slot> `;
`72`	`68`	`}`