tests

Author: nielslyngsoe

packages/uui-menu-item/lib/uui-menu-item.element.ts

@@ -250,6 +250,11 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
   @state()
   private iconSlotHasContent = false;
 
+  connectedCallback() {
+    super.connectedCallback();
+    if (!this.hasAttribute('role')) this.setAttribute('role', 'menu');
+  }
+
   private iconSlotChanged(e: any): void {
     this.iconSlotHasContent =
       (e.target as HTMLSlotElement).assignedNodes({ flatten: true }).length > 0;

packages/uui-menu-item/lib/uui-menu-item.test.ts

@@ -13,10 +13,14 @@ describe('UUIMenuItemElement', () => {
 
   beforeEach(async () => {
     element = await fixture(
-      html`<uui-menu-item role="menu" label="menuitem"></uui-menu-item>`
+      html`<uui-menu-item label="menuitem"></uui-menu-item>`
     );
   });
 
+  it('is defined', () => {
+    expect(element).to.be.instanceOf(UUIMenuItemElement);
+  });
+
   it('passes the a11y audit', async () => {
     await expect(element).shadowDom.to.be.accessible();
   });
@@ -133,4 +137,42 @@ describe('UUIMenuItemElement', () => {
       expect(element.selected).to.be.false;
     });
   });
+
+  describe('HREF', () => {
+    let labelElement: HTMLElement;
+    let element: UUIMenuItemElement;
+
+    beforeEach(async () => {
+      element = await fixture(
+        html`<uui-menu-item
+          label="menuitem"
+          href="https://www.umbraco.com"></uui-menu-item>`
+      );
+      labelElement = element.shadowRoot!.querySelector(
+        '#label-button'
+      ) as HTMLElement;
+    });
+
+    it('label element is defined', () => {
+      expect(labelElement).to.be.instanceOf(HTMLElement);
+    });
+
+    it('label is rendered as an anchor tag', async () => {
+      await elementUpdated(element);
+      expect(labelElement.nodeName).to.be.equal('A');
+    });
+
+    it('target is applied to anchor tag', async () => {
+      element.target = '_self';
+      await elementUpdated(element);
+      expect(labelElement.getAttribute('target')).to.be.equal('_self');
+    });
+
+    it('when target is _blank rel=noopener is set.', async () => {
+      element.target = '_blank';
+      await elementUpdated(element);
+      expect(labelElement.getAttribute('target')).to.be.equal('_blank');
+      expect(labelElement.getAttribute('rel')).to.be.equal('noopener');
+    });
+  });
 });