Skip to content

Commit 33d4a75

Browse files
committed
Remove getter setter from properties
1 parent aec30d4 commit 33d4a75

File tree

1 file changed

+12
-45
lines changed

1 file changed

+12
-45
lines changed

packages/uui-pagination/lib/uui-pagination.element.ts

Lines changed: 12 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -126,61 +126,36 @@ export class UUIPaginationElement extends LitElement {
126126
@property({ reflect: true, attribute: 'aria-label' })
127127
ariaLabel = '';
128128

129-
private _firstLabel = 'First';
130129
/**
131130
* This property is used to generate the name of the first button
132131
* @type {string}
133132
* @attr
134133
*/
135134
@property({ type: String })
136-
get firstLabel() {
137-
return this._firstLabel;
138-
}
139-
set firstLabel(newValue: string) {
140-
this._firstLabel = newValue;
141-
}
135+
firstLabel: string = 'First';
142136

143-
private _previousLabel = 'Previous';
144137
/**
145138
* This property is used to generate the name of the previous button
146139
* @type {string}
147140
* @attr
148141
*/
149142
@property({ type: String })
150-
get previousLabel() {
151-
return this._previousLabel;
152-
}
153-
set previousLabel(newValue: string) {
154-
this._previousLabel = newValue;
155-
}
143+
previousLabel: string = 'Previous';
156144

157-
private _nextLabel = 'Next';
158145
/**
159146
* This property is used to generate the name of the next button
160147
* @type {string}
161148
* @attr
162149
*/
163150
@property({ type: String })
164-
get nextLabel() {
165-
return this._nextLabel;
166-
}
167-
set nextLabel(newValue: string) {
168-
this._nextLabel = newValue;
169-
}
170-
171-
private _lastLabel = 'Last';
151+
nextLabel: string = 'Next';
172152
/**
173153
* This property is used to generate the name of the last button
174154
* @type {string}
175155
* @attr
176156
*/
177157
@property({ type: String })
178-
get lastLabel() {
179-
return this._lastLabel;
180-
}
181-
set lastLabel(newValue: string) {
182-
this._lastLabel = newValue;
183-
}
158+
lastLabel: string = 'Last';
184159

185160
private _total = 100;
186161

@@ -270,11 +245,9 @@ export class UUIPaginationElement extends LitElement {
270245
look="outline"
271246
class="nav"
272247
role="listitem"
273-
label="Go to first page"
248+
label=${this.firstLabel}
274249
?disabled=${this._current === 1}
275-
@click=${() => this.goToPage(1)}>
276-
${this.firstLabel}
277-
</uui-button>`;
250+
@click=${() => this.goToPage(1)}></uui-button>`;
278251
}
279252

280253
protected renderPrevious() {
@@ -283,11 +256,9 @@ export class UUIPaginationElement extends LitElement {
283256
look="outline"
284257
class="nav"
285258
role="listitem"
286-
label="Go to previous page"
259+
label=${this.previousLabel}
287260
?disabled=${this._current === 1}
288-
@click=${this.goToPreviousPage}>
289-
${this.previousLabel}
290-
</uui-button>`;
261+
@click=${this.goToPreviousPage}></uui-button>`;
291262
}
292263

293264
protected renderNext() {
@@ -296,11 +267,9 @@ export class UUIPaginationElement extends LitElement {
296267
look="outline"
297268
role="listitem"
298269
class="nav"
299-
label="Go to next page"
270+
label=${this.nextLabel}
300271
?disabled=${this._current === this.total}
301-
@click=${this.goToNextPage}>
302-
${this.nextLabel}
303-
</uui-button>`;
272+
@click=${this.goToNextPage}></uui-button>`;
304273
}
305274

306275
protected renderLast() {
@@ -310,11 +279,9 @@ export class UUIPaginationElement extends LitElement {
310279
look="outline"
311280
role="listitem"
312281
class="nav"
313-
label="Go to last page"
282+
label=${this.lastLabel}
314283
?disabled=${this.total === this._current}
315-
@click=${() => this.goToPage(this.total)}>
316-
${this.lastLabel}
317-
</uui-button>
284+
@click=${() => this.goToPage(this.total)}></uui-button>
318285
`;
319286
}
320287

0 commit comments

Comments
 (0)