Skip to content

Commit 37a085b

Browse files
committed
Refactored rel attribute value/markup
1 parent e1886fc commit 37a085b

File tree

4 files changed

+8
-24
lines changed

4 files changed

+8
-24
lines changed

packages/uui-card-block-type/lib/uui-card-block-type.element.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,15 @@ export class UUICardBlockTypeElement extends UUICardElement {
7171

7272
#renderLink() {
7373
const tabIndex = !this.disabled ? (this.selectOnly ? -1 : 0) : undefined;
74+
const rel = this.target === '_blank' ? 'noopener noreferrer' : undefined;
7475
return html`
7576
<a
7677
id="open-part"
7778
class="uui-text"
7879
tabindex=${ifDefined(tabIndex)}
7980
href=${ifDefined(!this.disabled ? this.href : undefined)}
8081
target=${ifDefined(this.target || undefined)}
81-
rel=${ifDefined(
82-
this.rel ||
83-
ifDefined(
84-
this.target === '_blank' ? 'noopener noreferrer' : undefined,
85-
),
86-
)}>
82+
rel=${ifDefined(this.rel || rel)}>
8783
${this.#renderContent()}
8884
</a>
8985
`;

packages/uui-card-content-node/lib/uui-card-content-node.element.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,18 +100,14 @@ export class UUICardContentNodeElement extends UUICardElement {
100100

101101
#renderLink() {
102102
const tabIndex = !this.disabled ? (this.selectOnly ? -1 : 0) : undefined;
103+
const rel = this.target === '_blank' ? 'noopener noreferrer' : undefined;
103104
return html`
104105
<a
105106
id="open-part"
106107
tabindex=${ifDefined(tabIndex)}
107108
href=${ifDefined(!this.disabled ? this.href : undefined)}
108109
target=${ifDefined(this.target || undefined)}
109-
rel=${ifDefined(
110-
this.rel ||
111-
ifDefined(
112-
this.target === '_blank' ? 'noopener noreferrer' : undefined,
113-
),
114-
)}>
110+
rel=${ifDefined(this.rel || rel)}>
115111
${this.#renderContent()}
116112
</a>
117113
`;

packages/uui-card-media/lib/uui-card-media.element.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,18 +85,14 @@ export class UUICardMediaElement extends UUICardElement {
8585

8686
#renderLink() {
8787
const tabIndex = !this.disabled ? (this.selectOnly ? -1 : 0) : undefined;
88+
const rel = this.target === '_blank' ? 'noopener noreferrer' : undefined;
8889
return html`
8990
<a
9091
id="open-part"
9192
tabindex=${ifDefined(tabIndex)}
9293
href=${ifDefined(!this.disabled ? this.href : undefined)}
9394
target=${ifDefined(this.target || undefined)}
94-
rel=${ifDefined(
95-
this.rel ||
96-
ifDefined(
97-
this.target === '_blank' ? 'noopener noreferrer' : undefined,
98-
),
99-
)}>
95+
rel=${ifDefined(this.rel || rel)}>
10096
${this.#renderContent()}
10197
</a>
10298
`;

packages/uui-card-user/lib/uui-card-user.element.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,14 @@ export class UUICardUserElement extends UUICardElement {
5454

5555
#renderLink() {
5656
const tabIndex = !this.disabled ? (this.selectOnly ? -1 : 0) : undefined;
57+
const rel = this.target === '_blank' ? 'noopener noreferrer' : undefined;
5758
return html`
5859
<a
5960
id="open-part"
6061
tabindex=${ifDefined(tabIndex)}
6162
href=${ifDefined(!this.disabled ? this.href : undefined)}
6263
target=${ifDefined(this.target || undefined)}
63-
rel=${ifDefined(
64-
this.rel ||
65-
ifDefined(
66-
this.target === '_blank' ? 'noopener noreferrer' : undefined,
67-
),
68-
)}>
64+
rel=${ifDefined(this.rel || rel)}>
6965
${this.#renderContent()}
7066
</a>
7167
`;

0 commit comments

Comments
 (0)