Skip to content

Commit 57711bf

Browse files
committed
fix: makes the beforetoggle event listener passive and move to constructor
1 parent d2b3113 commit 57711bf

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

packages/uui-popover-container/lib/uui-popover-container.element.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,20 @@ export class UUIPopoverContainerElement extends LitElement {
7272
#sizeObserver: ResizeObserver | null = null;
7373
#size: { width: number; height: number } = { width: 0, height: 0 };
7474

75+
constructor() {
76+
super();
77+
78+
this.addEventListener('beforetoggle', this.#onBeforeToggle, {
79+
passive: true,
80+
});
81+
}
82+
7583
connectedCallback(): void {
84+
super.connectedCallback();
7685
if (!this.hasAttribute('popover')) {
7786
this.setAttribute('popover', '');
7887
}
7988

80-
super.connectedCallback();
81-
this.addEventListener('beforetoggle', this.#onBeforeToggle);
82-
8389
if (!this.#sizeObserver) {
8490
this.#sizeObserver = new ResizeObserver(entries => {
8591
const element = entries[0]; // should be only one
@@ -101,7 +107,6 @@ export class UUIPopoverContainerElement extends LitElement {
101107

102108
disconnectedCallback(): void {
103109
super.disconnectedCallback();
104-
this.removeEventListener('beforetoggle', this.#onBeforeToggle);
105110
this.#stopScrollListener();
106111
this.#sizeObserver?.disconnect();
107112
this.#sizeObserver = null;

0 commit comments

Comments
 (0)