Skip to content

Commit 98fffa9

Browse files
committed
fix icon in table by fixing empty label for checkbox
1 parent ac890d0 commit 98fffa9

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

packages/uui-base/lib/mixins/LabelMixin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export const LabelMixin = <T extends Constructor<LitElement>>(
6565
: ''}
6666
<slot
6767
class="label"
68-
style=${this._labelSlotHasContent ? '' : 'visibility: hidden'}
68+
style=${this._labelSlotHasContent ? '' : 'display: none'}
6969
name=${labelSlotName ? labelSlotName : ''}
7070
@slotchange=${this.labelSlotChanged}></slot>
7171
`;

packages/uui-boolean-input/lib/uui-boolean-input.element.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,10 @@ export abstract class UUIBooleanInputElement extends UUIFormControlMixin(
256256
.label {
257257
display: block;
258258
}
259+
260+
span.label:empty {
261+
display: none;
262+
}
259263
`,
260264
];
261265
}

packages/uui-table/lib/uui-table-advanced-example.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export class UUITableWithSelectionExampleElement extends LitElement {
199199
@selected=${() => this._selectRowHandler(item)}
200200
@deselected=${() => this._deselectRowHandler(item)}>
201201
<uui-table-cell>
202-
<uui-icon name="wand" style="font-size: 20px;"></uui-icon>
202+
<uui-icon name="wand"></uui-icon>
203203
<uui-checkbox
204204
@click=${(e: MouseEvent) => e.stopPropagation()}
205205
@change=${(event: Event) => this._selectHandler(event, item)}

0 commit comments

Comments
 (0)