Skip to content

Commit 9dc03e7

Browse files
committed
docs(storybook): move events to SelectableMixin base class
This also fixes a mixup of events that was forgotten
1 parent 3f13ef8 commit 9dc03e7

File tree

5 files changed

+13
-19
lines changed

5 files changed

+13
-19
lines changed

packages/uui-base/lib/mixins/SelectableMixin.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { LitElement } from 'lit';
22
import { property } from 'lit/decorators.js';
3+
34
import { UUISelectableEvent } from '../events/UUISelectableEvent';
45

56
type Constructor<T = {}> = new (...args: any[]) => T;
@@ -19,6 +20,10 @@ export declare class SelectableMixinInterface extends LitElement {
1920
export const SelectableMixin = <T extends Constructor<LitElement>>(
2021
superClass: T
2122
) => {
23+
/**
24+
* @fires {UUISelectableEvent} selected - fires when the media card is selected
25+
* @fires {UUISelectableEvent} unselected - fires when the media card is unselected
26+
*/
2227
class SelectableMixinClass extends superClass {
2328
private _selectable = false;
2429
/**

packages/uui-card-content-node/lib/uui-card-content-node.element.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
1-
import { UUICardElement } from '@umbraco-ui/uui-card/lib';
21
import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
2+
import { UUICardElement } from '@umbraco-ui/uui-card/lib';
33
import { css, html, nothing } from 'lit';
44
import { property, state } from 'lit/decorators.js';
55

66
/**
77
* @element uui-card-content-node
8-
* @fires {UUICardEvent} open - fires when the card title is clicked
9-
* @fires {UUICardEvent} selected - fires when the card is selected
108
* @description - Card component for displaying a content-node.
119
*/
12-
1310
@defineElement('uui-card-content-node')
1411
export class UUICardContentNodeElement extends UUICardElement {
1512
static styles = [

packages/uui-card-media/lib/uui-card-media.element.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
1-
import { UUICardElement } from '@umbraco-ui/uui-card/lib';
21
import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
2+
import { UUICardElement } from '@umbraco-ui/uui-card/lib';
33
import { css, html, nothing } from 'lit';
44
import { property, state } from 'lit/decorators.js';
55

66
/**
77
* @element uui-card-media
8-
* @fires {UUICardEvent} open - fires when the media card title is clicked
9-
* @fires {UUICardEvent} selected - fires when the card is selected
108
* @description - Card component for displaying a media item.
119
*/
12-
1310
@defineElement('uui-card-media')
1411
export class UUICardMediaElement extends UUICardElement {
1512
static styles = [

packages/uui-card-user/lib/uui-card-user.element.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
1-
import { UUICardElement } from '@umbraco-ui/uui-card/lib';
21
import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
2+
import { UUICardElement } from '@umbraco-ui/uui-card/lib';
33
import { css, html, nothing } from 'lit';
44
import { property } from 'lit/decorators.js';
55

66
/**
77
* @element uui-card-user
8-
* @fires {UUICardEvent} open - fires when the user card title is clicked
9-
* @fires {UUICardEvent} selected - fires when the card is selected
108
* @description - Card component for displaying a user node.
119
*/
12-
1310
@defineElement('uui-card-user')
1411
export class UUICardUserElement extends UUICardElement {
1512
static styles = [

packages/uui-card/lib/uui-card.element.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,18 @@
1-
import { LitElement, css } from 'lit';
2-
import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
3-
import { property } from 'lit/decorators.js';
41
import {
52
SelectableMixin,
63
SelectOnlyMixin,
74
} from '@umbraco-ui/uui-base/lib/mixins';
5+
import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
6+
import { css, LitElement } from 'lit';
7+
import { property } from 'lit/decorators.js';
8+
89
import { UUICardEvent } from './UUICardEvent';
910

1011
/**
1112
* @element uui-card
12-
* @fires {UUICardEvent} open - fires when the media card title is clicked
13-
* @fires {UUISelectableEvent} select - fires when the media card is selected
14-
* @fires {UUISelectableEvent} unselect - fires when the media card is unselected
13+
* @fires {UUICardEvent} open - fires when the card title is clicked
1514
* @description - Base card component to be extended by specific cards.
1615
*/
17-
1816
@defineElement('uui-card')
1917
export class UUICardElement extends SelectOnlyMixin(
2018
SelectableMixin(LitElement)

0 commit comments

Comments
 (0)