feat: remove registration warning

madsrasmussen · web-flow · commit aca2ebfccc90 · 2022-03-25T13:42:04.000+01:00
This warning would fire if the element was already registered. We will enable it again with export conditions in a future version.
diff --git a/packages/uui-base/lib/registration/index.ts b/packages/uui-base/lib/registration/index.ts
@@ -21,9 +21,7 @@ export function defineElement(
 
     const existingElement = window.customElements.get(name);
 
-    if (existingElement) {
-      console.warn(`${name} is already defined`, existingElement); // TODO: Remove this in production
-    } else {
+    if (!existingElement) {
       window.customElements.define(name, constructor, options);
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,7 @@ export function defineElement(`
`21`	`21`
`22`	`22`	`const existingElement = window.customElements.get(name);`
`23`	`23`
`24`		`- if (existingElement) {`
`25`		- console.warn(`${name} is already defined`, existingElement); // TODO: Remove this in production
`26`		`- } else {`
	`24`	`+ if (!existingElement) {`
`27`	`25`	`window.customElements.define(name, constructor, options);`
`28`	`26`	`}`
`29`	`27`	`};`