Merge branch 'dev' into feature/css-variables

Author: JesmoDev

.github/workflows/pr-first-response.yml

@@ -1,26 +1,53 @@
 name: pr-first-response
 
 on:
-  pull_request:
+  pull_request_target:
     types: [opened]
 
-jobs:
+jobs: 
   send-response:
     runs-on: ubuntu-latest
+    permissions:
+      issues: write
+      pull-requests: write    
     steps:
-      - name: Fetch random comment 🗣️
-        uses: JamesIves/[email protected]
-        with:
-          ENDPOINT: https://collaboratorsv2.euwest01.umbraco.io/umbraco/api/comments/PostComment
-          CONFIGURATION: '{ "method": "POST", "headers": {"Authorization": "Bearer ${{ secrets.OUR_BOT_API_TOKEN }}", "Content-Type": "application/json" }, "body": { "repo": "${{ github.repository }}", "number": "${{ github.event.number }}", "actor": "${{ github.actor }}", "commentType": "opened-pr-first-comment"} }'
-      - name: Add PR comment
-        if: "${{ env.fetch-api-data != '' }}"
-        uses: actions/github-script@v5
+      - name: Install dependencies
+        run: |
+          npm install node-fetch@2
+      - name: Fetch random comment 🗣️ and add it to the PR
+        uses: actions/github-script@v6
         with:
           script: |
-            github.rest.issues.createComment({
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              body: `${{ env.fetch-api-data }}`
-            })
+            const fetch = require('node-fetch')
+
+            const response = await fetch('https://collaboratorsv2.euwest01.umbraco.io/umbraco/api/comments/PostComment', {
+              method: 'post',
+              body: JSON.stringify({
+                repo: '${{ github.repository }}',
+                number: '${{ github.event.number }}',
+                actor: '${{ github.actor }}',
+                commentType: 'opened-pr-first-comment'
+              }),
+              headers: {
+                'Authorization': 'Bearer ${{ secrets.OUR_BOT_API_TOKEN }}',
+                'Content-Type': 'application/json'
+              }
+            });
+
+            try {
+                const data = await response.text();
+
+                if(response.status === 200 && data !== '') {
+                    github.rest.issues.createComment({
+                        issue_number: context.issue.number,
+                        owner: context.repo.owner,
+                        repo: context.repo.repo,
+                        body: data
+                    });
+                } else {
+                    console.log("Status code did not indicate success:", response.status);
+                    console.log("Returned data:", data);
+                }
+            } catch(error) {
+                console.log(error);
+            }

.storybook/preview-head.html

@@ -14,8 +14,12 @@
     /* reset defaults: */
     margin: 24px;
     position: relative;
+  }
+
+  body.sb-main-padded {
     padding: 40px !important;
   }
+
   body[baseline-grid]::after {
     content: '';
     position: absolute;

README.md

@@ -37,6 +37,8 @@ If you want to develop a component or contribute to the repository go to ["Get s
 | [`<uui-card-user>`](https://github.com/umbraco/Umbraco.UI/tree/dev/packages/uui-card-user)                                       | [![npm](https://img.shields.io/npm/v/@umbraco-ui/uui-card-user?logoColor=%231B264F)](https://www.npmjs.com/package/@umbraco-ui/uui-card-user)                                       |
 | [`<uui-caret>`](https://github.com/umbraco/Umbraco.UI/tree/dev/packages/uui-caret)                                               | [![npm](https://img.shields.io/npm/v/@umbraco-ui/uui-caret?logoColor=%231B264F)](https://www.npmjs.com/package/@umbraco-ui/uui-caret)                                               |
 | [`<uui-checkbox>`](https://github.com/umbraco/Umbraco.UI/tree/dev/packages/uui-checkbox)                                         | [![npm](https://img.shields.io/npm/v/@umbraco-ui/uui-checkbox?logoColor=%231B264F)](https://www.npmjs.com/package/@umbraco-ui/uui-checkbox)                                         |
+| [`<uui-combobox>`](https://github.com/umbraco/Umbraco.UI/tree/dev/packages/uui-combobox)                                         | [![npm](https://img.shields.io/npm/v/@umbraco-ui/uui-combobox?logoColor=%231B264F)](https://www.npmjs.com/package/@umbraco-ui/uui-combobox)                                         |
+| [`<uui-combobox-list>`](https://github.com/umbraco/Umbraco.UI/tree/dev/packages/uui-combobox-list)                               | [![npm](https://img.shields.io/npm/v/@umbraco-ui/uui-combobox-list?logoColor=%231B264F)](https://www.npmjs.com/package/@umbraco-ui/uui-combobox-list)                               |
 | [`<uui-dialog>`](https://github.com/umbraco/Umbraco.UI/tree/dev/packages/uui-dialog)                                             | [![npm](https://img.shields.io/npm/v/@umbraco-ui/uui-dialog?logoColor=%231B264F)](https://www.npmjs.com/package/@umbraco-ui/uui-dialog)                                             |
 | [`<uui-dialog-layout>`](https://github.com/umbraco/Umbraco.UI/tree/dev/packages/uui-dialog-layout)                               | [![npm](https://img.shields.io/npm/v/@umbraco-ui/uui-dialog-layout?logoColor=%231B264F)](https://www.npmjs.com/package/@umbraco-ui/uui-dialog-layout)                               |
 | [`<uui-file-dropzone>`](https://github.com/umbraco/Umbraco.UI/tree/dev/packages/uui-file-dropzone)                               | [![npm](https://img.shields.io/npm/v/@umbraco-ui/uui-file-dropzone?logoColor=%231B264F)](https://www.npmjs.com/package/@umbraco-ui/uui-file-dropzone)                               |

docs/CONTRIBUTING.md

@@ -4,7 +4,7 @@ Please review this document to help to streamline the process and save everyone'
 
 This repo uses nodejs, so you should install `nodejs` as the package manager. See [installation guide](https://nodejs.org/en/).
 
-# Guidelines for contributions we welcome
+# Guidelines for contributions that we welcome
 
 Not all changes are wanted, so on occasion we might close a PR without merging it. We will give you feedback why we can't accept your changes and we'll be nice about it, thanking you for spending your valuable time.
 
@@ -47,6 +47,13 @@ The UI Library components are [web components](https://developer.mozilla.org/en-
 
 Using Typescript is mandatory when contributing to this repository, although it is not necessary to use it when consuming the components.
 
+### How to get started
+
+1. Make sure you have the recommended version of node.js and npm installed
+   1. Currently we use node.js v16 and npm v8
+2. Run `npm install`
+3. Run `npm run storybook` to start the storybook server, which we also use for development
+
 ### New component
 
 You can create a new component and that way contribute to the UI library. But before you do that, go to the [`./src/components`](https://github.com/umbraco/Umbraco.UI/tree/dev/src/components) and check if it's not already there. Components from that folder are very much WIP will be gradually moved to packages. You may also look for an inspiration in this [components list](COMPONENTS.md), where you can check what component is in what stage.

images/login.jpeg

@@ -10,16 +10,22 @@
     }
   },
   "ignoreChanges": [
+    ".github/**/*",
     "**/tsconfig.json",
     "**/*.story.ts",
     "**/*.test.ts",
     "**/*.md",
     "lerna.json",
     ".storybook/**/*",
+    "stories/**/*",
     "storyhelpers/**/*",
     "templates/**/*",
     "docs/**/*",
     "package.json",
-    "package-lock.json"
+    "package-lock.json",
+    "images/**/*",
+    "scripts/**/*",
+    "src/**/*",
+    "templates/**/*"
   ]
 }