Skip to content

Commit b8437b0

Browse files
authored
Merge branch 'v1/contrib' into feature/uui-copy
2 parents ac50a35 + 9ef7f28 commit b8437b0

File tree

16 files changed

+48
-41
lines changed

16 files changed

+48
-41
lines changed

packages/uui-box/lib/uui-box.element.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ export class UUIBoxElement extends LitElement {
131131
132132
#header {
133133
display: flex;
134+
align-items: center;
134135
column-gap: var(--uui-size-space-5);
135136
border-bottom: 1px solid var(--uui-color-divider-standalone);
136137
padding: var(

packages/uui-button/lib/uui-button.element.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,9 +293,12 @@ export class UUIButtonElement extends UUIFormControlMixin(
293293
294294
.label {
295295
line-height: normal; /** needed to reset 'a > span' */
296-
display: block;
297296
transition: opacity 120ms;
297+
display: flex;
298+
gap: var(--uui-size-1);
299+
align-items: center;
298300
}
301+
299302
:host([state]:not([state=''])) .label {
300303
opacity: 0;
301304
}

packages/uui-card-block-type/lib/uui-card-block-type.element.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,12 @@ export class UUICardBlockTypeElement extends UUICardElement {
5757
return html`
5858
<button
5959
id="open-part"
60+
class="uui-text"
6061
tabindex=${this.disabled ? (nothing as any) : '0'}
6162
@click=${this.handleOpenClick}
6263
@keydown=${this.handleOpenKeydown}>
63-
<strong>${this.name}</strong><small>${this.description}</small>
64+
<span id="name">${this.name}</span>
65+
<small>${this.description}</small>
6466
</button>
6567
`;
6668
}
@@ -69,6 +71,7 @@ export class UUICardBlockTypeElement extends UUICardElement {
6971
return html`
7072
<a
7173
id="open-part"
74+
class="uui-text"
7275
tabindex=${this.disabled ? (nothing as any) : '0'}
7376
href=${ifDefined(!this.disabled ? this.href : undefined)}
7477
target=${ifDefined(this.target || undefined)}
@@ -78,7 +81,8 @@ export class UUICardBlockTypeElement extends UUICardElement {
7881
this.target === '_blank' ? 'noopener noreferrer' : undefined,
7982
),
8083
)}>
81-
<strong>${this.name}</strong><small>${this.description}</small>
84+
<span id="name">${this.name}</span>
85+
<small>${this.description}</small>
8286
</a>
8387
`;
8488
}
@@ -121,12 +125,11 @@ export class UUICardBlockTypeElement extends UUICardElement {
121125
border-top: 1px solid var(--uui-color-divider);
122126
border-radius: 0 0 var(--uui-border-radius) var(--uui-border-radius);
123127
font-family: inherit;
124-
font-size: var(--uui-type-small-size);
125128
box-sizing: border-box;
126129
padding: var(--uui-size-2) var(--uui-size-4);
127130
display: flex;
128131
flex-direction: column;
129-
line-height: var(--uui-size-6);
132+
line-height: normal;
130133
}
131134
132135
:host([disabled]) #open-part {

packages/uui-card-content-node/lib/uui-card-content-node.element.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export class UUICardContentNodeElement extends UUICardElement {
6868

6969
#renderContent() {
7070
return html`
71-
<span id="content">
71+
<span id="content" class="uui-text">
7272
<span id="item">
7373
<span id="icon">
7474
<slot name="icon" @slotchange=${this._onSlotIconChange}></slot>
@@ -167,7 +167,6 @@ export class UUICardContentNodeElement extends UUICardElement {
167167
#open-part {
168168
display: flex;
169169
position: relative;
170-
font-weight: 700;
171170
align-items: center;
172171
cursor: pointer;
173172
flex-grow: 1;

packages/uui-card-media/lib/uui-card-media.element.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,12 @@ export class UUICardMediaElement extends UUICardElement {
102102

103103
#renderContent() {
104104
return html`
105-
<div id="content">
105+
<div id="content" class="uui-text">
106106
<!--
107107
TODO: Implement info box when pop-out is ready
108108
-->
109109
<span id="name">${this.name}</span>
110-
${this.detail}<slot name="detail"></slot>
110+
<small id="detail">${this.detail}<slot name="detail"></slot></small>
111111
</div>
112112
`;
113113
}
@@ -200,7 +200,6 @@ export class UUICardMediaElement extends UUICardElement {
200200
width: 100%;
201201
align-items: center;
202202
font-family: inherit;
203-
font-size: var(--uui-type-small-size);
204203
box-sizing: border-box;
205204
text-align: left;
206205
word-break: break-word;
@@ -219,8 +218,8 @@ export class UUICardMediaElement extends UUICardElement {
219218
opacity: 0.96;
220219
}
221220
222-
#name {
223-
font-weight: 700;
221+
#detail {
222+
opacity: 0.6;
224223
}
225224
226225
:host(

packages/uui-card/lib/uui-card.element.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import {
33
SelectOnlyMixin,
44
} from '@umbraco-ui/uui-base/lib/mixins';
55
import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
6+
import { UUITextStyles } from '@umbraco-ui/uui-css/lib';
67
import { css, html, LitElement } from 'lit';
78
import { property } from 'lit/decorators.js';
89

@@ -87,6 +88,7 @@ export class UUICardElement extends SelectOnlyMixin(
8788
}
8889

8990
static styles = [
91+
UUITextStyles,
9092
css`
9193
:host {
9294
position: relative;

packages/uui-combobox-list/lib/uui-combobox-list-option.element.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,12 @@ export class UUIComboboxListOptionElement extends SelectableMixin(
8585
:host {
8686
position: relative;
8787
cursor: pointer;
88-
margin: 0 4px;
88+
margin: 1px var(--uui-size-2);
8989
border-radius: var(--uui-border-radius);
9090
outline: 2px solid transparent;
9191
outline-offset: -2px;
92-
padding-left: 4px;
92+
padding: var(--uui-size-1);
93+
padding-left: var(--uui-size-2);
9394
}
9495
9596
:host(:first-child) {

packages/uui-css/lib/custom-properties.story.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ export const Sizing = () => html`
488488
// <h5>Headline H5</h5>
489489
// <br />
490490
// <p>
491-
// The default font-size is 15px, for a nice reading experience this conforms
491+
// The default font-size is 14px, for a nice reading experience this conforms
492492
// well with a line-height of 24px, which is our base-unit times 4.
493493
// </p>
494494
// <p>

packages/uui-css/lib/custom-properties/sizes.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@
5353
--uui-border-radius: var(--uui-size-1);
5454

5555
/** Typography */
56-
--uui-type-default-size: var(--uui-size-5);
57-
--uui-type-small-size: var(--uui-size-4);
56+
--uui-type-default-size: 14px;
57+
--uui-type-small-size: 12px;
5858
--uui-type-h1-size: 60px; /*--uui-size-20*/
5959
--uui-type-h2-size: 42px; /*--uui-size-14*/
6060
--uui-type-h3-size: 30px; /*--uui-size-10*/

packages/uui-css/lib/guidelines.story.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export const Typography = () => html`
116116
class 'uui-lead' to a &#60;p&#62; element.
117117
</p>
118118
<p>
119-
The default font-size is 15px, for a nice reading experience this conforms
119+
The default font-size is 14px, for a nice reading experience this conforms
120120
well with a line-height of 24px, (base-unit * 4).
121121
</p>
122122

0 commit comments

Comments
 (0)