Make the sonar code quality thing a bit happier

Author: warrenbuckley

packages/uui-copy/lib/UUICopyEvent.ts

@@ -1,11 +1,15 @@
 import { UUIEvent } from '@umbraco-ui/uui-base/lib/events';
 import { UUICopyElement } from './uui-copy.element';
 
+interface UUICopyEventInit extends EventInit {
+  detail?: { text: string };
+}
+
 export class UUICopyEvent extends UUIEvent<{ text: string }, UUICopyElement> {
   public static readonly COPIED: string = 'copied';
   public static readonly COPYING: string = 'copying';
 
-  constructor(evName: string, eventInit: any | null = {}) {
+  constructor(evName: string, eventInit: UUICopyEventInit = {}) {
     super(evName, {
       ...{ bubbles: true },
       ...eventInit,

packages/uui-copy/lib/uui-copy.element.ts

@@ -83,7 +83,7 @@ export class UUICopyElement extends LabelMixin('', LitElement) {
   // Used to store the value that will be copied to the clipboard
   #valueToCopy = '';
 
-  #onClick = async (e: Event) => {
+  readonly #onClick = async (e: Event) => {
     const button = e.target as UUIButtonElement;
     button.state = 'waiting';
 
@@ -96,7 +96,7 @@ export class UUICopyElement extends LabelMixin('', LitElement) {
       const el = document.getElementById(this.copyFrom);
       if (el) {
         console.log('Element found to copy from', el);
-        this.#valueToCopy = el.textContent || el.innerText || '';
+        this.#valueToCopy = el.textContent ?? el.innerText ?? '';
 
         // Override the value to copy ,if the element has a value property
         // Such as uui-input or uui-textarea or native inout elements
@@ -123,7 +123,6 @@ export class UUICopyElement extends LabelMixin('', LitElement) {
     await navigator.clipboard
       .writeText(this.#valueToCopy)
       .then(() => {
-        //button.state = 'success';
         this.dispatchEvent(
           new UUICopyEvent(UUICopyEvent.COPIED, {
             detail: { text: this.#valueToCopy },
@@ -151,7 +150,7 @@ export class UUICopyElement extends LabelMixin('', LitElement) {
     </uui-button>`;
   }
 
-  static styles = [
+  static readonly styles = [
     css`
       slot {
         pointer-events: none;