Skip to content

Commit da99d41

Browse files
committed
implement hover states
1 parent 7c83388 commit da99d41

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

packages/uui-menu-item/lib/uui-menu-item.element.ts

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
297297
var(--uui-color-current)
298298
);
299299
}
300-
:host([active]) #label-button:hover ~ #label-button-background,
300+
:host([active]) :has(#label-button:hover) #label-button-background,
301301
:host([active]) #caret-button:hover {
302302
background-color: var(
303303
--uui-menu-item-background-color-active-hover,
@@ -332,8 +332,8 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
332332
}
333333
/** Selected, not highlight mode */
334334
:host([selected]:not([select-mode='highlight'], [disabled]))
335-
#label-button:hover
336-
~ #label-button-background,
335+
:has(#label-button:hover)
336+
#label-button-background,
337337
:host([selected]:not([select-mode='highlight'], [disabled]))
338338
#caret-button:hover {
339339
background-color: var(
@@ -345,8 +345,8 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
345345
/** highlight mode, default */
346346
:host([select-mode='highlight']:not([disabled], [active], [selectable]))
347347
#menu-item
348-
#label-button:hover
349-
~ #label-button-background {
348+
:has(#label-button:hover)
349+
#label-button-background {
350350
border-radius: var(--uui-border-radius);
351351
background-color: var(
352352
--uui-menu-item-background-color-highlight,
@@ -364,8 +364,8 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
364364
/** highlight mode, active & selected */
365365
:host([select-mode='highlight'][active][selected]:not([disabled]))
366366
#menu-item
367-
#label-button:hover
368-
~ #label-button-background {
367+
:has(#label-button:hover)
368+
#label-button-background {
369369
border-radius: var(--uui-border-radius);
370370
background-color: var(
371371
--uui-menu-item-background-color-highlight-active-selected,
@@ -444,14 +444,14 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
444444
445445
:host([select-mode='highlight'][selectable]:not([disabled]))
446446
#menu-item
447-
#label-button:hover
448-
~ #label-button-background::after {
447+
:has(#label-button:hover)
448+
#label-button-background::after {
449449
opacity: 0.33;
450450
}
451451
:host([select-mode='highlight'][selected]:not([disabled]))
452452
#menu-item
453-
#label-button:hover
454-
~ #label-button-background::after {
453+
:has(#label-button:hover)
454+
#label-button-background::after {
455455
opacity: 0.66;
456456
}
457457
@@ -476,7 +476,6 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
476476
background-color: transparent;
477477
cursor: pointer;
478478
min-height: var(--uui-size-12);
479-
/* z-index: 1; */
480479
}
481480
482481
#label-button {
@@ -494,7 +493,6 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
494493
text-decoration: none;
495494
color: currentColor;
496495
min-height: var(--uui-size-12);
497-
/* z-index: 1; */
498496
font-weight: inherit;
499497
}
500498

0 commit comments

Comments
 (0)