feat: change _onInput method from private to protected (#196)

julczka · iOvergaard · commit de26ed2b3e44 · 2022-04-13T10:18:56.000+02:00
diff --git a/packages/uui-input/lib/uui-input.element.ts b/packages/uui-input/lib/uui-input.element.ts
@@ -264,10 +264,11 @@ export class UUIInputElement extends FormControlMixin(LitElement) {
     return this._input;
   }
 
-  private _onInput(e: Event) {
+  protected _onInput(e: Event) {
     this.value = (e.target as HTMLInputElement).value;
 
     // TODO: Do we miss an input event?
+    // No, this event is already composed and bubbles, so th enative one just goes out and works. Change is not though. (see more https://html.spec.whatwg.org/multipage/input.html#common-input-element-events)
   }
 
   private _onChange() {

Original file line number	Diff line number	Diff line change
`@@ -264,10 +264,11 @@ export class UUIInputElement extends FormControlMixin(LitElement) {`
`264`	`264`	`return this._input;`
`265`	`265`	`}`
`266`	`266`
`267`		`- private _onInput(e: Event) {`
	`267`	`+ protected _onInput(e: Event) {`
`268`	`268`	`this.value = (e.target as HTMLInputElement).value;`
`269`	`269`
`270`	`270`	`// TODO: Do we miss an input event?`
	`271`	`+ // No, this event is already composed and bubbles, so th enative one just goes out and works. Change is not though. (see more https://html.spec.whatwg.org/multipage/input.html#common-input-element-events)`
`271`	`272`	`}`
`272`	`273`
`273`	`274`	`private _onChange() {`