Skip to content

Commit 0daad10

Browse files
committed
Removed duplicate code and add note for obsolete method
1 parent 56d1491 commit 0daad10

File tree

1 file changed

+1
-17
lines changed

1 file changed

+1
-17
lines changed

14/umbraco-cms/reference/routing/request-pipeline/icontentfinder.md

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ public class My404ContentFinder : IContentLastChanceFinder
164164
public Task<bool> TryFindContent(IPublishedRequestBuilder contentRequest)
165165
{
166166
// Find the root node with a matching domain to the incoming request
167-
var allDomains = _domainService.GetAll(true).ToList();
167+
var allDomains = _domainService.GetAll(true).ToList(); // <---- IDomainService.GetAll(bool)' is obsolete: 'Please use GetAllAsync. Will be removed in V15'
168168
var domain = allDomains?
169169
.FirstOrDefault(f => f.DomainName == contentRequest.Uri.Authority
170170
|| f.DomainName == $"https://{contentRequest.Uri.Authority}"
@@ -177,22 +177,6 @@ public class My404ContentFinder : IContentLastChanceFinder
177177
return Task.FromResult(false);
178178
}
179179

180-
public Task<bool> TryFindContent(IPublishedRequestBuilder contentRequest)
181-
{
182-
// Find the root node with a matching domain to the incoming request
183-
var allDomains = _domainService.GetAll(true).ToList();
184-
var domain = allDomains?
185-
.FirstOrDefault(f => f.DomainName == contentRequest.Uri.Authority
186-
|| f.DomainName == $"https://{contentRequest.Uri.Authority}"
187-
|| f.DomainName == $"http://{contentRequest.Uri.Authority}");
188-
189-
var siteId = domain != null ? domain.RootContentId : allDomains.Any() ? allDomains.FirstOrDefault()?.RootContentId : null;
190-
191-
if (!_umbracoContextAccessor.TryGetUmbracoContext(out var umbracoContext))
192-
{
193-
return Task.FromResult(false);
194-
}
195-
196180
if (umbracoContext.Content == null)
197181
return new Task<bool>(() => contentRequest.PublishedContent is not null);
198182

0 commit comments

Comments
 (0)